From: Quan Nguyen <quan@os.amperecomputing.com>
To: corey@minyard.net, Cosmo Chou <chou.cosmo@gmail.com>
Cc: minyard@acm.org, openipmi-developer@lists.sourceforge.net,
linux-kernel@vger.kernel.org, cosmo.chou@quantatw.com,
potin.lai@quantatw.com
Subject: Re: [PATCH] ipmi: ssif_bmc: Move smbus_cmd assignment after cleanup
Date: Fri, 3 Jan 2025 10:49:59 +0700 [thread overview]
Message-ID: <12ed4d01-9fe8-4d2b-af5a-fdb0ebe38bf1@os.amperecomputing.com> (raw)
In-Reply-To: <Z3dXaMlZ1zTt5HHd@mail.minyard.net>
On 03/01/2025 10:20, Corey Minyard wrote:
> On Thu, Jan 02, 2025 at 12:54:31AM +0800, Cosmo Chou wrote:
>> Move smbus_cmd assignment to the end of process_smbus_cmd() to ensure
>> the new command is not lost when complete_response() is triggered.
>
> Ok, I see, patch is applied. Thank you.
>
> Quan, I assume this is ok. Please double-check it for me.
>
Yes, Corey,
This patch looks good to me and I think this can be improved a bit
further in my reply for Cosmo.
- Quan
next prev parent reply other threads:[~2025-01-03 3:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-01 16:54 Cosmo Chou
2025-01-03 3:20 ` Corey Minyard
2025-01-03 3:49 ` Quan Nguyen [this message]
2025-01-03 3:44 ` Quan Nguyen
2025-01-03 13:01 ` Corey Minyard
2025-01-06 2:32 ` Quan Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=12ed4d01-9fe8-4d2b-af5a-fdb0ebe38bf1@os.amperecomputing.com \
--to=quan@os.amperecomputing.com \
--cc=chou.cosmo@gmail.com \
--cc=corey@minyard.net \
--cc=cosmo.chou@quantatw.com \
--cc=linux-kernel@vger.kernel.org \
--cc=minyard@acm.org \
--cc=openipmi-developer@lists.sourceforge.net \
--cc=potin.lai@quantatw.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®