From: Jarkko Nikula <jarkko.nikula@linux.intel.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>,
Evan Green <evgreen@chromium.org>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Lee Jones <lee.jones@linaro.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1] mfd: intel-lpss: Add Intel Comet Lake PCI IDs
Date: Tue, 30 Apr 2019 14:34:26 +0300 [thread overview]
Message-ID: <12f48b95-7a45-919e-0eb5-30e00e692743@linux.intel.com> (raw)
In-Reply-To: <CAHp75Vfw8-jfzgOBwyTk6E5sqsSxh1NVPnLdQHyZJZneruT3uA@mail.gmail.com>
On 4/16/19 10:55 AM, Andy Shevchenko wrote:
> On Tue, Apr 16, 2019 at 6:10 AM Evan Green <evgreen@chromium.org> wrote:
>> On Tue, Apr 9, 2019 at 11:11 PM Andy Shevchenko
>> <andriy.shevchenko@linux.intel.com> wrote:
>>>
>>> Intel Comet Lake has the same LPSS than Intel Cannon Lake.
>>> Add the new IDs to the list of supported devices.
>
>>> static const struct pci_device_id intel_lpss_pci_ids[] = {
>>> + /* CML */
>>> + { PCI_VDEVICE(INTEL, 0x02a8), (kernel_ulong_t)&spt_uart_info },
>>> + { PCI_VDEVICE(INTEL, 0x02a9), (kernel_ulong_t)&spt_uart_info },
>>> + { PCI_VDEVICE(INTEL, 0x02aa), (kernel_ulong_t)&spt_info },
>>> + { PCI_VDEVICE(INTEL, 0x02ab), (kernel_ulong_t)&spt_info },
>>> + { PCI_VDEVICE(INTEL, 0x02c5), (kernel_ulong_t)&bxt_i2c_info },
>>> + { PCI_VDEVICE(INTEL, 0x02c6), (kernel_ulong_t)&bxt_i2c_info },
>>
>> How come it's not cnl_i2c_info?
>
> This is a good question, that's why Jarkko asked Lee to hold on until
> we have confirmation about i2c timings.
>
I got confirmation I2C uses the same input clock than Cannon Lake and
matches with my measurements.
Andy: please do s/bxt_i2c_info/cnl_i2c_info/ in your patch.
--
Jarkko
prev parent reply other threads:[~2019-04-30 11:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-09 15:11 Andy Shevchenko
2019-04-10 8:05 ` Jarkko Nikula
2019-04-16 3:08 ` Evan Green
2019-04-16 7:55 ` Andy Shevchenko
2019-04-30 11:34 ` Jarkko Nikula [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=12f48b95-7a45-919e-0eb5-30e00e692743@linux.intel.com \
--to=jarkko.nikula@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=andy.shevchenko@gmail.com \
--cc=evgreen@chromium.org \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome