From: Jinjie Ruan <ruanjinjie@huawei.com>
To: Thomas Gleixner <tglx@linutronix.de>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -next] genirq: Reuse irq_is_nmi()
Date: Tue, 23 Apr 2024 10:16:51 +0800 [thread overview]
Message-ID: <12f4d203-615b-0937-857e-ef0a478cd183@huawei.com> (raw)
In-Reply-To: <87r0exun6e.ffs@tglx>
On 2024/4/23 5:01, Thomas Gleixner wrote:
> On Wed, Apr 17 2024 at 16:56, Jinjie Ruan wrote:
>>
>> +static bool __maybe_unused irq_is_nmi(struct irq_desc *desc)
>
> Seriously? What's wrong with static inline?
Use "static bool" has follwoing warning:
kernel/irq/internals.h:283:13: warning: ‘irq_is_nmi’ defined but not
used [-Wunused-function]
283 | static bool irq_is_nmi(struct irq_desc *desc)
But us "static inline bool" is ok.
I'll change it to inline, thank you very much!
>
prev parent reply other threads:[~2024-04-23 2:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-17 8:56 Jinjie Ruan
2024-04-22 21:01 ` Thomas Gleixner
2024-04-23 2:16 ` Jinjie Ruan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=12f4d203-615b-0937-857e-ef0a478cd183@huawei.com \
--to=ruanjinjie@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®