From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1163711AbdEZGx2 (ORCPT ); Fri, 26 May 2017 02:53:28 -0400 Received: from smtp-out-no.shaw.ca ([64.59.134.13]:44429 "EHLO smtp-out-no.shaw.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965062AbdEZGxZ (ORCPT ); Fri, 26 May 2017 02:53:25 -0400 X-Greylist: delayed 300 seconds by postgrey-1.27 at vger.kernel.org; Fri, 26 May 2017 02:53:25 EDT X-Authority-Analysis: v=2.2 cv=dZbw5Tfe c=1 sm=1 tr=0 a=JyAt4amVi6RK7kaaDbhaBA==:117 a=JyAt4amVi6RK7kaaDbhaBA==:17 a=IkcTkHD0fZMA:10 a=tJ8p9aeEuA8A:10 a=VwQbUJbxAAAA:8 a=OLL_FvSJAAAA:8 a=pZqd25DbTP_OMCDrHUQA:9 a=QEXdDO2ut3YA:10 a=mME6OV7f7T8A:10 a=_qBF44UEXYgA:10 a=AjGcO6oz07-iQ99wixmX:22 a=oIrB72frpwYPwTMnlWqB:22 Subject: Re: [PATCH v2] PCI: Add ATS-disable quirk for AMD Stoney GPUs To: "Deucher, Alexander" , "'Joerg Roedel'" Cc: "'David Woodhouse'" , "'Joerg Roedel'" , Bjorn Helgaas , "linux-pci@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Daniel Drake References: <1491575538-22694-1-git-send-email-joro@8bytes.org> <1493893297.4904.71.camel@infradead.org> <20170524084450.GB12353@suse.de> From: Samuel Sieb Message-ID: <12fe83a5-23ec-3a29-5ed6-ff02175f818a@sieb.net> Date: Thu, 25 May 2017 23:48:14 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-CA Content-Transfer-Encoding: 8bit X-CMAE-Envelope: MS4wfNT2cq/go+970JaN4s03qJz7odJDgQBlP/pyy+uIa4NuQ4SuqU/siWUbd+0GL7cvkcLNyWuOSuOJHpP+iT9rAH8fCPTLcohtUaGwuEcASBBOUCuZPAA6 dEzPykDF52lVRrwZG/fcNloj9H9sZwl9AWW4SJj/KQ4Voc3OX4SMWWlBO8YUXQlTjwTOJ9/QbVKmuJc/yLH/0aOJBC7pSjujO7J27Iwxf3nL8SBR2C1ymppC w6rqrR/TKDLIAO7uFHKxXY3jrQ0cUqYgZPPwP/xyW+3T2W/UcHiGUclStJ8J6HlUfIVXSigXP4s6jPDGwXQEB2KoWeaV+L9soFD3UQXKTBKlJyAQspi6CLJv ysTRBeWhy5mMWmZHISJarhsmjttCqImczIuSbaGradyJy7J48aw= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/24/2017 05:56 AM, Deucher, Alexander wrote: >> -----Original Message----- >> From: Joerg Roedel [mailto:jroedel@suse.de] >> Sent: Wednesday, May 24, 2017 4:45 AM >> To: Deucher, Alexander >> Cc: 'David Woodhouse'; 'Joerg Roedel'; Bjorn Helgaas; linux- >> pci@vger.kernel.org; linux-kernel@vger.kernel.org; Daniel Drake; Samuel >> Sieb >> Subject: Re: [PATCH v2] PCI: Add ATS-disable quirk for AMD Stoney GPUs >> >> Hi Alexander, >> >> On Tue, May 23, 2017 at 07:54:12PM +0000, Deucher, Alexander wrote: >>> I finally got an answer from the hw team and we validated ATS on >>> stoney as well so in theory this patch shouldn’t actually be needed. >>> I think we may actually be papering over some other issue. The >>> following patch seems to also fix this issue (and other issues): >>> https://www.spinics.net/lists/stable/msg172631.html >> >> Yeah, but it still looks to me like that the hardware got into some >> weird state with the storm of ATS invalidations sent to it. >> >> The Completion-Wait loop timeouts seen in the original bug report >> indicate that the IOMMU is waiting for a response that never comes. And >> this is probably the ATS flush completion response from the GPU, as >> disabling ATS on the GPU makes the issue disappear. > > Yeah, it's weird. My ack on the patch still stands. Just adding some additional data. > I just tested this patch without the previous ATS disabling patch (I verified that ATS was enabled). Doing a stress-test kernel build while running a 3D graphical application caused no disk corruption. That was running for several hours. If it's not the solution, it sure hides the problem really well.