mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Slava Pestov <slavapestov@google.com>
Cc: linux-kernel@vger.kernel.org, mrubin@google.com, dhsharp@google.com
Subject: Re: [PATCH] ftrace: add a new 'tail drops' counter for overflow events
Date: Mon, 14 Mar 2011 22:39:54 -0400	[thread overview]
Message-ID: <1300156794.9910.249.camel@gandalf.stny.rr.com> (raw)
In-Reply-To: <1300143236-23233-1-git-send-email-slavapestov@google.com>

On Mon, 2011-03-14 at 15:53 -0700, Slava Pestov wrote:
> The existing 'overrun' counter is incremented when the ring
> buffer wraps around, with overflow on (the default). We wanted
> a way to count requests lost from the buffer filling up with
> overflow off, too. I decided to add a new counter instead
> of retro-fitting the existing one because it seems like a
> different statistic to count conceptually, and also because
> of how the code was structured.

So this is when we are in producer/consumer mode and the ring buffer
fills up and events are dropped.

For this we could just add a new ring buffer type. We could use the
RINGBUF_TYPE_TIME_STAMP as and call it RINGBUF_TYPE_LOST_EVENTS instead.
I never implemented the TIME_STAMP as I never found a need to ;)

As we currently have a TIME_EXTEND that is still relative from the last
event but has a total of 59 bits for time. That being nanoseconds we can
handle events that are 18 years apart. That far apart and never being
read.

The LOST_EVENTS could store the number of events lost when it starts
reading again. This way raw readers will know that events were lost and
how many.

-- Steve


> 
> Signed-Off-By: Slava Pestov <slavapestov@google.com>



  reply	other threads:[~2011-03-15  2:39 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-14 22:53 Slava Pestov
2011-03-15  2:39 ` Steven Rostedt [this message]
2011-03-15  4:13   ` David Sharp

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1300156794.9910.249.camel@gandalf.stny.rr.com \
    --to=rostedt@goodmis.org \
    --cc=dhsharp@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mrubin@google.com \
    --cc=slavapestov@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®