From: Shaohua Li <shaohua.li@intel.com>
To: Jens Axboe <jaxboe@fusionio.com>
Cc: lkml <linux-kernel@vger.kernel.org>,
Vivek Goyal <vgoyal@redhat.com>, Jeff Moyer <jmoyer@redhat.com>,
Corrado Zoccolo <czoccolo@gmail.com>,
Gui Jianfeng <guijianfeng@cn.fujitsu.com>
Subject: [PATCH]cfq-iosched: removing unnecessary think time checking
Date: Tue, 15 Mar 2011 10:57:31 +0800 [thread overview]
Message-ID: <1300157851.2337.78.camel@sli10-conroe> (raw)
Removing think time checking. A high thinktime queue might means the queue
dispatches several requests and then do away. Limitting such queue seems
meaningless. And also this can simplify code. This is suggested by Vivek.
Signed-off-by: Shaohua Li <shaohua.li@intel.com>
---
block/cfq-iosched.c | 13 ++++---------
1 file changed, 4 insertions(+), 9 deletions(-)
Index: linux/block/cfq-iosched.c
===================================================================
--- linux.orig/block/cfq-iosched.c 2011-03-10 13:52:13.000000000 +0800
+++ linux/block/cfq-iosched.c 2011-03-10 13:53:08.000000000 +0800
@@ -2418,19 +2418,14 @@ static bool cfq_may_dispatch(struct cfq_
return false;
/*
- * If there is only one sync queue, and its think time is
- * small, we can ignore async queue here and give the sync
+ * If there is only one sync queue
+ * we can ignore async queue here and give the sync
* queue no dispatch limit. The reason is a sync queue can
* preempt async queue, limiting the sync queue doesn't make
* sense. This is useful for aiostress test.
*/
- if (cfq_cfqq_sync(cfqq) && cfqd->busy_sync_queues == 1) {
- struct cfq_io_context *cic = RQ_CIC(cfqq->next_rq);
-
- if (sample_valid(cic->ttime_samples) &&
- cic->ttime_mean < cfqd->cfq_slice_idle)
- promote_sync = true;
- }
+ if (cfq_cfqq_sync(cfqq) && cfqd->busy_sync_queues == 1)
+ promote_sync = true;
/*
* We have other queues, don't allow more IO from this one
next reply other threads:[~2011-03-15 2:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-15 2:57 Shaohua Li [this message]
2011-03-15 15:56 ` Vivek Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1300157851.2337.78.camel@sli10-conroe \
--to=shaohua.li@intel.com \
--cc=czoccolo@gmail.com \
--cc=guijianfeng@cn.fujitsu.com \
--cc=jaxboe@fusionio.com \
--cc=jmoyer@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®