From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753362Ab1COE7V (ORCPT <rfc822;w@1wt.eu>);
	Tue, 15 Mar 2011 00:59:21 -0400
Received: from mail.linux-iscsi.org ([67.23.28.174]:43351 "EHLO
	linux-iscsi.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753037Ab1COE7R (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 15 Mar 2011 00:59:17 -0400
Subject: Re: [RFC-v2 12/12] iscsi-target: Add Makefile/Kconfig and update
	TCM top level
From: "Nicholas A. Bellinger" <nab@linux-iscsi.org>
To: Jesper Juhl <jj@chaosbits.net>
Cc: linux-scsi <linux-scsi@vger.kernel.org>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        James Bottomley <James.Bottomley@HansenPartnership.com>,
        Christoph Hellwig <hch@lst.de>, Mike Christie <michaelc@cs.wisc.edu>,
        Hannes Reinecke <hare@suse.de>,
        FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>,
        Boaz Harrosh <bharrosh@panasas.com>,
        Stephen Rothwell <sfr@canb.auug.org.au>,
        Douglas Gilbert <dgilbert@interlog.com>
In-Reply-To: <alpine.LNX.2.00.1103150201050.26293@swampdragon.chaosbits.net>
References: <1300103829-10337-1-git-send-email-nab@linux-iscsi.org>
	 <1300103829-10337-13-git-send-email-nab@linux-iscsi.org>
	 <alpine.LNX.2.00.1103150201050.26293@swampdragon.chaosbits.net>
Content-Type: text/plain
Date: Mon, 14 Mar 2011 21:52:13 -0700
Message-Id: <1300164733.28255.267.camel@haakon2.linux-iscsi.org>
Mime-Version: 1.0
X-Mailer: Evolution 2.22.3.1 
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, 2011-03-15 at 02:03 +0100, Jesper Juhl wrote:
> On Mon, 14 Mar 2011, Nicholas A. Bellinger wrote:
> 
> > From: Nicholas Bellinger <nab@linux-iscsi.org>
> > 
> [...]
> > diff --git a/drivers/target/Makefile b/drivers/target/Makefile
> > index 60028fe..b038b7d 100644
> > --- a/drivers/target/Makefile
> > +++ b/drivers/target/Makefile
> > @@ -24,3 +24,4 @@ obj-$(CONFIG_TCM_PSCSI)		+= target_core_pscsi.o
> >  
> >  # Fabric modules
> >  obj-$(CONFIG_TCM_LOOP_FABRIC)	+= tcm_loop/
> > +obj-$(CONFIG_ISCSI_TARGET)	+= iscsi/
> > diff --git a/drivers/target/iscsi/Kconfig b/drivers/target/iscsi/Kconfig
> > new file mode 100644
> > index 0000000..cc34243
> > --- /dev/null
> > +++ b/drivers/target/iscsi/Kconfig
> > @@ -0,0 +1,17 @@
> > +config ISCSI_TARGET
> > +	tristate "Linux-iSCSI.org iSCSI Target Mode Stack"
> > +	select CRYPTO
> > +	select CRYPTO_CRC32C
> > +	select CRYPTO_CRC32C_INTEL if X86
> > +	help
> > +	Say Y here to enable the ConfigFS enabled Linux-iSCSI.org iSCSI
> > +	Target Mode Stack.
> > +
> > +if ISCSI_TARGET
> > +
> > +config ISCSI_TARGET_DEBUG
> > +	bool "LIO-Target iscsi_debug.h ring buffer messages"
> > +	help
> > +	Say Y here to enable the legacy DEBUG_ISCSI macros in iscsi_debug.h
> > +
> > +endif
> [...]
> 
> Perhaps this is a stupid question, but if these are "legacy" macros, why 
> not save our users from having to deal with a new config option that is 
> presumably going to go away again soon-ish and instead make those legacy 
> macros go away sooner rather than later?
> 

A fair point here.  Perhaps calling them 'legacy' is a bit harsh, as
these are still useful for short-term v4.1 iSCSI target debugging
purposes.  In the long run these do need to be converted to use debugfs
(along with the rest of drivers/target/ as well), but this is currently
a lower priority item on the TODO for the initial merge.

Best Regards,

--nab