mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Florian Mickler <florian@mickler.org>
To: mchehab@infradead.org
Cc: oliver@neukum.org, jwjstone@fastmail.fm,
	Florian Mickler <florian@mickler.org>,
	linux-kernel@vger.kernel.org,
	Mauro Carvalho Chehab <mchehab@redhat.com>,
	linux-media@vger.kernel.org
Subject: [PATCH 03/16] [media] a800: get rid of on-stack dma buffers
Date: Tue, 15 Mar 2011 09:43:35 +0100	[thread overview]
Message-ID: <1300178655-24832-3-git-send-email-florian@mickler.org> (raw)
In-Reply-To: <1300178655-24832-1-git-send-email-florian@mickler.org>

usb_control_msg initiates (and waits for completion of) a dma transfer using
the supplied buffer. That buffer thus has to be seperately allocated on
the heap.

In lib/dma_debug.c the function check_for_stack even warns about it:
	WARNING: at lib/dma-debug.c:866 check_for_stack

Note: This change is tested to compile only, as I don't have the hardware.

Signed-off-by: Florian Mickler <florian@mickler.org>
---
 drivers/media/dvb/dvb-usb/a800.c |   17 +++++++++++++----
 1 files changed, 13 insertions(+), 4 deletions(-)

diff --git a/drivers/media/dvb/dvb-usb/a800.c b/drivers/media/dvb/dvb-usb/a800.c
index 53b93a4..fe2366b 100644
--- a/drivers/media/dvb/dvb-usb/a800.c
+++ b/drivers/media/dvb/dvb-usb/a800.c
@@ -78,17 +78,26 @@ static struct rc_map_table rc_map_a800_table[] = {
 
 static int a800_rc_query(struct dvb_usb_device *d, u32 *event, int *state)
 {
-	u8 key[5];
+	int ret;
+	u8 *key = kmalloc(5, GFP_KERNEL);
+	if (!key)
+		return -ENOMEM;
+
 	if (usb_control_msg(d->udev,usb_rcvctrlpipe(d->udev,0),
 				0x04, USB_TYPE_VENDOR | USB_DIR_IN, 0, 0, key, 5,
-				2000) != 5)
-		return -ENODEV;
+				2000) != 5) {
+		ret = -ENODEV;
+		goto out;
+	}
 
 	/* call the universal NEC remote processor, to find out the key's state and event */
 	dvb_usb_nec_rc_key_to_event(d,key,event,state);
 	if (key[0] != 0)
 		deb_rc("key: %x %x %x %x %x\n",key[0],key[1],key[2],key[3],key[4]);
-	return 0;
+	ret = 0;
+out:
+	kfree(key);
+	return ret;
 }
 
 /* USB Driver stuff */
-- 
1.7.4.rc3


  parent reply	other threads:[~2011-03-15  8:54 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-06 11:16 [PATCH] [media] dib0700: " Florian Mickler
2011-03-06 12:06 ` Oliver Neukum
2011-03-06 14:38   ` Florian Mickler
2011-03-06 14:45     ` [PATCH 1/3 v2] " Florian Mickler
2011-03-06 14:45       ` [PATCH 2/3] [media] dib0700: remove unused variable Florian Mickler
2011-03-06 14:45       ` [PATCH 3/3] [media] dib0700: don't ignore errors in driver probe Florian Mickler
2011-03-06 15:06     ` [PATCH] [media] dib0700: get rid of on-stack dma buffers Oliver Neukum
2011-03-06 15:45       ` Florian Mickler
2011-03-06 16:44         ` Oliver Neukum
2011-03-06 17:47           ` [PATCH 1/2 v3] " Florian Mickler
2011-03-06 17:47             ` [PATCH 2/2] [media] dib0700: remove unused variable Florian Mickler
2011-03-06 17:57             ` [PATCH 1/2 v3] [media] dib0700: get rid of on-stack dma buffers Florian Mickler
2011-03-15  8:36               ` Florian Mickler
2011-03-15  8:43                 ` [PATCH 01/16] " Florian Mickler
2011-03-15  8:43                   ` [PATCH 02/16] [media] dib0700: remove unused variable Florian Mickler
2011-03-15  8:43                   ` Florian Mickler [this message]
2011-03-15  8:43                   ` [PATCH 04/16] [media] vp7045: get rid of on-stack dma buffers Florian Mickler
2011-03-15  8:43                   ` [PATCH 05/16] [media] ec168: get rid of on stack " Florian Mickler
2011-03-18 16:36                     ` Antti Palosaari
2011-03-18 21:33                       ` Florian Mickler
2011-03-15  8:43                   ` [PATCH 06/16] [media] ce6230: get rid of on-stack dma buffer Florian Mickler
2011-03-18 16:36                     ` Antti Palosaari
2011-03-18 21:28                       ` Florian Mickler
2011-03-15  8:43                   ` [PATCH 07/16] [media] friio: get rid of on-stack dma buffers Florian Mickler
2011-03-15  8:43                   ` [PATCH 11/16] [media] lmedm04: correct indentation Florian Mickler
2011-03-15  8:43                   ` [PATCH 12/16] [media] lmedm04: get rid of on-stack dma buffers Florian Mickler
2011-03-15 20:54                     ` Malcolm Priestley
2011-03-15 21:46                       ` Florian Mickler
2011-03-15 12:02                   ` [PATCH 01/16] [media] dib0700: " Mauro Carvalho Chehab
2011-03-15 21:14                     ` Florian Mickler
     [not found]                   ` <1300178655-24832-9-git-send-email-florian@mickler.org>
2011-03-18 16:34                     ` [PATCH 09/16] [media] au6610: get rid of on-stack dma buffer Antti Palosaari
2011-03-18 21:27                       ` Florian Mickler
2011-03-18 21:40                         ` Antti Palosaari
2011-03-15 11:37                 ` [PATCH 1/2 v3] [media] dib0700: get rid of on-stack dma buffers Mauro Carvalho Chehab
2011-03-06 13:49 ` [PATCH] " Jack Stone
2011-03-06 14:00   ` Florian Mickler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1300178655-24832-3-git-send-email-florian@mickler.org \
    --to=florian@mickler.org \
    --cc=jwjstone@fastmail.fm \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@infradead.org \
    --cc=mchehab@redhat.com \
    --cc=oliver@neukum.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®