From: Arnaldo Carvalho de Melo <acme@infradead.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: linux-kernel@vger.kernel.org,
Arnaldo Carvalho de Melo <acme@redhat.com>,
Frederic Weisbecker <fweisbec@gmail.com>,
Ingo Molnar <mingo@elte.hu>, Mike Galbraith <efault@gmx.de>,
Paul Mackerras <paulus@samba.org>,
Peter Zijlstra <peterz@infradead.org>,
Stephane Eranian <eranian@google.com>,
Tom Zanussi <tzanussi@gmail.com>
Subject: [PATCH 02/12] perf top: Remove redundant syme->origin field
Date: Tue, 15 Mar 2011 17:04:51 -0300 [thread overview]
Message-ID: <1300219501-15085-3-git-send-email-acme@infradead.org> (raw)
In-Reply-To: <1300219501-15085-1-git-send-email-acme@infradead.org>
From: Arnaldo Carvalho de Melo <acme@redhat.com>
We can get it from syme->map->dso->kernel (that should be renamed to
origin, but leave this for another patch).
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Stephane Eranian <eranian@google.com>
Cc: Tom Zanussi <tzanussi@gmail.com>
LKML-Reference: <new-submission>
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/builtin-top.c | 1 -
tools/perf/util/top.c | 4 ++--
tools/perf/util/top.h | 1 -
3 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/tools/perf/builtin-top.c b/tools/perf/builtin-top.c
index 4bf6e02..4976400 100644
--- a/tools/perf/builtin-top.c
+++ b/tools/perf/builtin-top.c
@@ -782,7 +782,6 @@ static void perf_event__process_sample(const union perf_event *event,
if (!syme->skip) {
struct perf_evsel *evsel;
- syme->origin = origin;
evsel = perf_evlist__id2evsel(top.evlist, sample->id);
assert(evsel != NULL);
syme->count[evsel->idx]++;
diff --git a/tools/perf/util/top.c b/tools/perf/util/top.c
index fcfb777..a11f607 100644
--- a/tools/perf/util/top.c
+++ b/tools/perf/util/top.c
@@ -184,9 +184,9 @@ float perf_top__decay_samples(struct perf_top *top, struct rb_root *root)
if (syme->snap_count != 0) {
if ((top->hide_user_symbols &&
- syme->origin == PERF_RECORD_MISC_USER) ||
+ syme->map->dso->kernel == DSO_TYPE_USER) ||
(top->hide_kernel_symbols &&
- syme->origin == PERF_RECORD_MISC_KERNEL)) {
+ syme->map->dso->kernel == DSO_TYPE_KERNEL)) {
perf_top__remove_active_sym(top, syme);
continue;
}
diff --git a/tools/perf/util/top.h b/tools/perf/util/top.h
index 96a7831..ba111b2 100644
--- a/tools/perf/util/top.h
+++ b/tools/perf/util/top.h
@@ -17,7 +17,6 @@ struct sym_entry {
unsigned long snap_count;
double weight;
int skip;
- u8 origin;
struct map *map;
unsigned long count[0];
};
--
1.6.2.5
next prev parent reply other threads:[~2011-03-15 20:05 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-15 20:04 [GIT PULL 00/12] perf/core improvements, fixes and cleanups Arnaldo Carvalho de Melo
2011-03-15 20:04 ` [PATCH 01/12] perf top: Remove redundant perf_top->sym_counter Arnaldo Carvalho de Melo
2011-03-15 20:04 ` Arnaldo Carvalho de Melo [this message]
2011-03-15 20:04 ` [PATCH 03/12] perf symbols: Rename dso->origin to dso->symtab_type Arnaldo Carvalho de Melo
2011-03-15 20:04 ` [PATCH 04/12] perf symbol: Move sym_entry->skip to symbol->ignore Arnaldo Carvalho de Melo
2011-03-15 20:04 ` [PATCH 05/12] perf stat: Provide support for filters Arnaldo Carvalho de Melo
2011-03-15 20:04 ` [PATCH 06/12] perf script: Change process_event prototype Arnaldo Carvalho de Melo
2011-03-15 20:04 ` [PATCH 07/12] perf tracing: Remove print_graph_cpu and print_graph_proc from trace-event-parse Arnaldo Carvalho de Melo
2011-03-15 20:04 ` [PATCH 08/12] perf script: Move printing of 'common' data from print_event and rename Arnaldo Carvalho de Melo
2011-03-15 20:04 ` [PATCH 09/12] perf script: Support custom field selection for output Arnaldo Carvalho de Melo
2011-03-15 20:04 ` [PATCH 10/12] perf script: Add support for dumping symbols Arnaldo Carvalho de Melo
2011-03-15 20:05 ` [PATCH 11/12] perf script: Add support for H/W and S/W events Arnaldo Carvalho de Melo
2011-03-15 20:05 ` [PATCH 12/12] perf evlist: New command to list the names of events present in a perf.data file Arnaldo Carvalho de Melo
2011-03-16 12:53 ` [GIT PULL 00/12] perf/core improvements, fixes and cleanups Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1300219501-15085-3-git-send-email-acme@infradead.org \
--to=acme@infradead.org \
--cc=acme@redhat.com \
--cc=efault@gmx.de \
--cc=eranian@google.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
--cc=peterz@infradead.org \
--cc=tzanussi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®