From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751856Ab1CPGu6 (ORCPT <rfc822;w@1wt.eu>);
	Wed, 16 Mar 2011 02:50:58 -0400
Received: from chilli.pcug.org.au ([203.10.76.44]:55153 "EHLO smtps.tip.net.au"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751656Ab1CPGuw (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Wed, 16 Mar 2011 02:50:52 -0400
Date: Wed, 16 Mar 2011 17:50:41 +1100
From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
Cc: linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
        Benjamin Herrenschmidt <benh@kernel.crashing.org>,
        Paul Mackerras <paulus@samba.org>, <linuxppc-dev@lists.ozlabs.org>
Subject: linux-next: build failure after merge of the final tree (ubi tree
 related)
Message-Id: <20110316175041.67c4f371.sfr@canb.auug.org.au>
X-Mailer: Sylpheed 3.1.0 (GTK+ 2.20.1; i486-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: multipart/signed; protocol="application/pgp-signature";
 micalg="PGP-SHA1";
 boundary="Signature=_Wed__16_Mar_2011_17_50_41_+1100_sK/33jNIqrHlMsb9"
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

--Signature=_Wed__16_Mar_2011_17_50_41_+1100_sK/33jNIqrHlMsb9
Content-Type: text/plain; charset=US-ASCII
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi all,

After merging the final tree, today's linux-next build (powerpc
allyesconfig) failed like this:

drivers/mtd/ubi/io.c: In function 'ubi_dbg_check_write':
drivers/mtd/ubi/io.c:1348: error: 'PAGE_KERNEL' undeclared (first use in th=
is function)
drivers/mtd/ubi/io.c: In function 'ubi_dbg_check_all_ff':
drivers/mtd/ubi/io.c:1412: error: 'PAGE_KERNEL' undeclared (first use in th=
is function)

Caused by commit 823ed5091113 ("UBI: allocate write checking buffer on dema=
nd").

I don't know how to fix this, so I have left it for today.
--=20
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

--Signature=_Wed__16_Mar_2011_17_50_41_+1100_sK/33jNIqrHlMsb9
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iQEcBAEBAgAGBQJNgF3BAAoJEDMEi1NhKgbsXy4H/2S0dcFSLT/PEKRDUuAzUn5s
U6hIcjOTRE6ZqSbsjyb3x7yodg+m3f36K9bqbbpXe3yoAU0nlLpQwBy7QQCuLx4n
YP0h/a2KedulYf2LHBf+jCI+tkfTYTLPxsoc+L8wK8Comu/lf8FONPXhGGLGVbhD
a70IVo0P5ZkQzpJnyY4hIQGr1oGPkj8fLnQjv1JRpCD06AgNS9FRcFL7Hoq7cdoi
pjbTT3V7nYL8A4wMmQz6mcifig3681CsrQAr0AT7YuJBRHVgUJHqHhEtNrV8t/lu
LCG1Mt6oVR2VeTWgvVMCGtaDAA3c61SBXSsTTCmiijery07r8GOOtgUU3GugUPw=
=7r7z
-----END PGP SIGNATURE-----

--Signature=_Wed__16_Mar_2011_17_50_41_+1100_sK/33jNIqrHlMsb9--

From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752167Ab1CPH1J (ORCPT <rfc822;w@1wt.eu>);
	Wed, 16 Mar 2011 03:27:09 -0400
Received: from smtp.nokia.com ([147.243.128.24]:43384 "EHLO mgw-da01.nokia.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751538Ab1CPH1D (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Wed, 16 Mar 2011 03:27:03 -0400
Subject: Re: linux-next: build failure after merge of the final tree (ubi
 tree related)
From: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
Reply-To: Artem.Bityutskiy@nokia.com
To: ext Stephen Rothwell <sfr@canb.auug.org.au>
Cc: linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
        Benjamin Herrenschmidt <benh@kernel.crashing.org>,
        Paul Mackerras <paulus@samba.org>, linuxppc-dev@lists.ozlabs.org
In-Reply-To: <20110316175041.67c4f371.sfr@canb.auug.org.au>
References: <20110316175041.67c4f371.sfr@canb.auug.org.au>
Content-Type: text/plain; charset="UTF-8"
Organization: Nokia
Date: Wed, 16 Mar 2011 09:22:50 +0200
Message-ID: <1300260170.2817.4.camel@localhost>
Mime-Version: 1.0
X-Mailer: Evolution 2.32.1 (2.32.1-1.fc14) 
Content-Transfer-Encoding: 8bit
X-Nokia-AV: Clean
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, 2011-03-16 at 17:50 +1100, ext Stephen Rothwell wrote:
> Hi all,
> 
> After merging the final tree, today's linux-next build (powerpc
> allyesconfig) failed like this:
> 
> drivers/mtd/ubi/io.c: In function 'ubi_dbg_check_write':
> drivers/mtd/ubi/io.c:1348: error: 'PAGE_KERNEL' undeclared (first use in this function)
> drivers/mtd/ubi/io.c: In function 'ubi_dbg_check_all_ff':
> drivers/mtd/ubi/io.c:1412: error: 'PAGE_KERNEL' undeclared (first use in this function)
> 
> Caused by commit 823ed5091113 ("UBI: allocate write checking buffer on demand").
> 
> I don't know how to fix this, so I have left it for today.

Hmm, strange, include <linux/vmalloc.h> should be enough to use
__vmalloc with 'PAGE_KERNEL' AFAICS, and we have this include... I'll
try to look better.

--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)


From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752581Ab1CPKPm (ORCPT <rfc822;w@1wt.eu>);
	Wed, 16 Mar 2011 06:15:42 -0400
Received: from gate.crashing.org ([63.228.1.57]:49605 "EHLO gate.crashing.org"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752270Ab1CPKPh (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Wed, 16 Mar 2011 06:15:37 -0400
Subject: Re: linux-next: build failure after merge of the final tree (ubi
 tree related)
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Artem.Bityutskiy@nokia.com
Cc: ext Stephen Rothwell <sfr@canb.auug.org.au>, linux-next@vger.kernel.org,
        linux-kernel@vger.kernel.org, Paul Mackerras <paulus@samba.org>,
        linuxppc-dev@lists.ozlabs.org
In-Reply-To: <1300260170.2817.4.camel@localhost>
References: <20110316175041.67c4f371.sfr@canb.auug.org.au>
	 <1300260170.2817.4.camel@localhost>
Content-Type: text/plain; charset="UTF-8"
Date: Wed, 16 Mar 2011 21:15:08 +1100
Message-ID: <1300270508.22236.1168.camel@pasglop>
Mime-Version: 1.0
X-Mailer: Evolution 2.30.3 
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, 2011-03-16 at 09:22 +0200, Artem Bityutskiy wrote:
> On Wed, 2011-03-16 at 17:50 +1100, ext Stephen Rothwell wrote:
> > Hi all,
> > 
> > After merging the final tree, today's linux-next build (powerpc
> > allyesconfig) failed like this:
> > 
> > drivers/mtd/ubi/io.c: In function 'ubi_dbg_check_write':
> > drivers/mtd/ubi/io.c:1348: error: 'PAGE_KERNEL' undeclared (first use in this function)
> > drivers/mtd/ubi/io.c: In function 'ubi_dbg_check_all_ff':
> > drivers/mtd/ubi/io.c:1412: error: 'PAGE_KERNEL' undeclared (first use in this function)
> > 
> > Caused by commit 823ed5091113 ("UBI: allocate write checking buffer on demand").
> > 
> > I don't know how to fix this, so I have left it for today.
> 
> Hmm, strange, include <linux/vmalloc.h> should be enough to use
> __vmalloc with 'PAGE_KERNEL' AFAICS, and we have this include... I'll
> try to look better.

Try adding asm/pgtable.h 

Cheers,
Ben.



From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752036Ab1CPKb1 (ORCPT <rfc822;w@1wt.eu>);
	Wed, 16 Mar 2011 06:31:27 -0400
Received: from smtp.nokia.com ([147.243.128.24]:57327 "EHLO mgw-da01.nokia.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1750703Ab1CPKbU (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Wed, 16 Mar 2011 06:31:20 -0400
Subject: Re: linux-next: build failure after merge of the final tree (ubi
 tree related)
From: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
Reply-To: Artem.Bityutskiy@nokia.com
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: ext Stephen Rothwell <sfr@canb.auug.org.au>, linux-next@vger.kernel.org,
        linux-kernel@vger.kernel.org, Paul Mackerras <paulus@samba.org>,
        linuxppc-dev@lists.ozlabs.org
In-Reply-To: <1300270508.22236.1168.camel@pasglop>
References: <20110316175041.67c4f371.sfr@canb.auug.org.au>
	 <1300260170.2817.4.camel@localhost>  <1300270508.22236.1168.camel@pasglop>
Content-Type: text/plain; charset="UTF-8"
Organization: Nokia
Date: Wed, 16 Mar 2011 12:27:37 +0200
Message-ID: <1300271257.2817.8.camel@localhost>
Mime-Version: 1.0
X-Mailer: Evolution 2.32.1 (2.32.1-1.fc14) 
Content-Transfer-Encoding: 8bit
X-Nokia-AV: Clean
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, 2011-03-16 at 21:15 +1100, Benjamin Herrenschmidt wrote:
> On Wed, 2011-03-16 at 09:22 +0200, Artem Bityutskiy wrote:
> > On Wed, 2011-03-16 at 17:50 +1100, ext Stephen Rothwell wrote:
> > > Hi all,
> > > 
> > > After merging the final tree, today's linux-next build (powerpc
> > > allyesconfig) failed like this:
> > > 
> > > drivers/mtd/ubi/io.c: In function 'ubi_dbg_check_write':
> > > drivers/mtd/ubi/io.c:1348: error: 'PAGE_KERNEL' undeclared (first use in this function)
> > > drivers/mtd/ubi/io.c: In function 'ubi_dbg_check_all_ff':
> > > drivers/mtd/ubi/io.c:1412: error: 'PAGE_KERNEL' undeclared (first use in this function)
> > > 
> > > Caused by commit 823ed5091113 ("UBI: allocate write checking buffer on demand").
> > > 
> > > I don't know how to fix this, so I have left it for today.
> > 
> > Hmm, strange, include <linux/vmalloc.h> should be enough to use
> > __vmalloc with 'PAGE_KERNEL' AFAICS, and we have this include... I'll
> > try to look better.
> 
> Try adding asm/pgtable.h 

Thanks, that's what I was thinking about as well.

-- 
Best Regards,
Artem Bityutskiy (Артём Битюцкий)


From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752480Ab1CPLwc (ORCPT <rfc822;w@1wt.eu>);
	Wed, 16 Mar 2011 07:52:32 -0400
Received: from smtp.nokia.com ([147.243.128.24]:49762 "EHLO mgw-da01.nokia.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751290Ab1CPLw0 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Wed, 16 Mar 2011 07:52:26 -0400
Subject: Re: linux-next: build failure after merge of the final tree (ubi
 tree related)
From: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
Reply-To: Artem.Bityutskiy@nokia.com
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
        Benjamin Herrenschmidt <benh@kernel.crashing.org>,
        Paul Mackerras <paulus@samba.org>, linuxppc-dev@lists.ozlabs.org
In-Reply-To: <20110316175041.67c4f371.sfr@canb.auug.org.au>
References: <20110316175041.67c4f371.sfr@canb.auug.org.au>
Content-Type: text/plain; charset="UTF-8"
Organization: Nokia
Date: Wed, 16 Mar 2011 13:48:39 +0200
Message-ID: <1300276119.2817.9.camel@localhost>
Mime-Version: 1.0
X-Mailer: Evolution 2.32.1 (2.32.1-1.fc14) 
Content-Transfer-Encoding: 8bit
X-Nokia-AV: Clean
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, 2011-03-16 at 17:50 +1100, Stephen Rothwell wrote:
> After merging the final tree, today's linux-next build (powerpc
> allyesconfig) failed like this:
> 
> drivers/mtd/ubi/io.c: In function 'ubi_dbg_check_write':
> drivers/mtd/ubi/io.c:1348: error: 'PAGE_KERNEL' undeclared (first use in this function)
> drivers/mtd/ubi/io.c: In function 'ubi_dbg_check_all_ff':
> drivers/mtd/ubi/io.c:1412: error: 'PAGE_KERNEL' undeclared (first use in this function)
> 
> Caused by commit 823ed5091113 ("UBI: allocate write checking buffer on demand").
> 
> I don't know how to fix this, so I have left it for today.

Fixed, sorry for the hassle and thank you!

-- 
Best Regards,
Artem Bityutskiy (Артём Битюцкий)


