From: Mike Frysinger <vapier@gentoo.org>
To: rtc-linux@googlegroups.com, Alessandro Zummo <a.zummo@towertech.it>
Cc: John Stultz <john.stultz@linaro.org>,
linux-kernel@vger.kernel.org, stable@kernel.org
Subject: [PATCH] rtc-bfin: add missing "return 0" in new alarm func
Date: Fri, 18 Mar 2011 04:26:24 -0400 [thread overview]
Message-ID: <1300436784-26543-1-git-send-email-vapier@gentoo.org> (raw)
The new bfin_rtc_alarm_irq_enable function forgot to add a "return 0" to
the end leading to the build warning:
drivers/rtc/rtc-bfin.c: In function 'bfin_rtc_alarm_irq_enable':
drivers/rtc/rtc-bfin.c:253: warning: control reaches end of non-void function
CC: stable@kernel.org
Signed-off-by: Mike Frysinger <vapier@gentoo.org>
---
drivers/rtc/rtc-bfin.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/rtc/rtc-bfin.c b/drivers/rtc/rtc-bfin.c
index 17971d9..0e61e2d 100644
--- a/drivers/rtc/rtc-bfin.c
+++ b/drivers/rtc/rtc-bfin.c
@@ -276,6 +276,8 @@ static int bfin_rtc_alarm_irq_enable(struct device *dev, unsigned int enabled)
bfin_rtc_int_set_alarm(rtc);
else
bfin_rtc_int_clear(~(RTC_ISTAT_ALARM | RTC_ISTAT_ALARM_DAY));
+
+ return 0;
}
static int bfin_rtc_read_time(struct device *dev, struct rtc_time *tm)
--
1.7.4.1
next reply other threads:[~2011-03-18 8:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-18 8:26 Mike Frysinger [this message]
2011-03-18 14:26 ` Harry Wei
2011-03-18 17:52 ` Mike Frysinger
[not found] ` <AANLkTinjTVpNbkiNKpbc7kvtMVeXfjifr7Q5Dg4B9oGE@mail.gmail.com>
[not found] ` <AANLkTinC_WCh2XXk-irG9d5QZvVU439_FYWZzTGQLbG7@mail.gmail.com>
2011-03-19 1:15 ` [PATCH] rtc-bfin: add missing "return 0" in new alarm func> On Fri, Mar 18, 2011 at 04:26:24AM -0400, Mike Frysinger wrote: Harry Wei
2011-03-19 1:18 ` [PATCH] rtc-bfin: add missing "return 0" in new alarm func John Stultz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1300436784-26543-1-git-send-email-vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=a.zummo@towertech.it \
--cc=john.stultz@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rtc-linux@googlegroups.com \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®