From: Benjamin Tissoires <benjamin.tissoires@enac.fr>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Henrik Rydberg <rydberg@euromail.se>,
Benjamin Tissoires <benjamin.tissoires@enac.fr>,
Jiri Kosina <jkosina@suse.cz>,
Stephane Chatty <chatty@lii-enac.fr>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v3 4/5] hid-multitouch: refactor initialization of ABS_MT_ORIENTATION
Date: Fri, 18 Mar 2011 14:27:55 +0100 [thread overview]
Message-ID: <1300454876-5017-5-git-send-email-benjamin.tissoires@enac.fr> (raw)
In-Reply-To: <1300454876-5017-1-git-send-email-benjamin.tissoires@enac.fr>
No semantic changes, it's just easier to read the code.
Signed-off-by: Benjamin Tissoires <benjamin.tissoires@enac.fr>
Reviewed-by: Stéphane Chatty <chatty@enac.fr>
---
new in v3
drivers/hid/hid-multitouch.c | 5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c
index e6e1ea2..d31301e 100644
--- a/drivers/hid/hid-multitouch.c
+++ b/drivers/hid/hid-multitouch.c
@@ -235,9 +235,8 @@ static int mt_input_mapping(struct hid_device *hdev, struct hid_input *hi,
case HID_DG_HEIGHT:
hid_map_usage(hi, usage, bit, max,
EV_ABS, ABS_MT_TOUCH_MINOR);
- field->logical_maximum = 1;
- field->logical_minimum = 0;
- set_abs(hi->input, ABS_MT_ORIENTATION, field, 0);
+ input_set_abs_params(hi->input,
+ ABS_MT_ORIENTATION, 0, 1, 0, 0);
td->last_slot_field = usage->hid;
return 1;
case HID_DG_TIPPRESSURE:
--
1.7.4
next prev parent reply other threads:[~2011-03-18 13:28 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-18 13:27 [PATCH 0/5] Migrations to hid-multitouch, round 3 Benjamin Tissoires
2011-03-18 13:27 ` [PATCH v3 1/5] hid-multitouch: Auto detection of maxcontacts Benjamin Tissoires
2011-03-21 8:47 ` Henrik Rydberg
2011-03-18 13:27 ` [PATCH v3 2/5] hid-multitouch: migrate support for Stantum panels to the unified driver Benjamin Tissoires
2011-03-21 8:49 ` Henrik Rydberg
2011-03-18 13:27 ` [PATCH v3 3/5] hid-multitouch: migrate Cando dual touch panels to hid-multitouch Benjamin Tissoires
2011-03-21 8:50 ` Henrik Rydberg
2011-03-18 13:27 ` Benjamin Tissoires [this message]
2011-03-21 9:02 ` [PATCH v3 4/5] hid-multitouch: refactor initialization of ABS_MT_ORIENTATION Henrik Rydberg
2011-03-21 13:32 ` Benjamin Tissoires
2011-03-21 13:50 ` Henrik Rydberg
2011-03-18 13:27 ` [PATCH v3 5/5] hid-multitouch: migrate 3M PCT touch screens to hid-multitouch Benjamin Tissoires
2011-03-21 9:05 ` Henrik Rydberg
2011-03-21 10:13 ` Benjamin Tissoires
2011-03-21 10:34 ` Henrik Rydberg
2011-03-21 19:06 ` Henrik Rydberg
2011-03-21 19:56 ` Benjamin Tissoires
2011-03-22 16:34 ` [PATCH v4] " Benjamin Tissoires
2011-03-22 16:58 ` Henrik Rydberg
2011-03-24 11:46 ` Jiri Kosina
2011-03-21 16:09 ` [PATCH 0/5] Migrations to hid-multitouch, round 3 Jiri Kosina
2011-03-21 18:22 ` Henrik Rydberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1300454876-5017-5-git-send-email-benjamin.tissoires@enac.fr \
--to=benjamin.tissoires@enac.fr \
--cc=chatty@lii-enac.fr \
--cc=dmitry.torokhov@gmail.com \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rydberg@euromail.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®