Re: [PATCH-v2] tcm_loop: Add multi-fabric Linux/SCSI LLD fabric module

["Nicholas A. Bellinger" <nab@linux-iscsi.org>]

On Mon, 2011-03-21 at 10:29 -0500, James Bottomley wrote:
> On Fri, 2011-03-18 at 15:39 -0700, Nicholas A. Bellinger wrote:
> > From: Nicholas Bellinger <nab@linux-iscsi.org>
> > 
> > This patch adds the TCM_Loop Linux/SCSI LLD fabric module for accessing TCM device
> > backstores as locally accessable SCSI LUNs in virtual SAS, FC, and iSCSI Target ports
> > using the generic fabric TransportID and Target Port WWN naming handlers from TCM's
> > target_core_fabric_lib.c  The TCM_Loop module uses the generic fabric configfs infratructure
> > provided by target_core_fabric_configfs.c and adds a module dependent attribute for the
> > creation/release of the virtual I_T Nexus connected the TCM_Loop Target and Initiator Ports.
> > 
> > TCM_Loop can also be used with scsi-generic and BSG drivers so that STGT userspace
> > fabric modules, QEMU-KVM and other hypervisor SCSI passthrough support can
> > access TCM device backstore and control CDB emulation.
> > 
> > For more information please see:
> > 
> > http://linux-iscsi.org/wiki/Tcm_loop
> > 
> > This patch has been updated with changes from Christoph's feedback.
> > 
> > Changed from v1 -> v2:
> > 
> > Remove dead extern prototypes and make all functions statically defined.
> > 
> > Signed-off-by: Nicholas A. Bellinger <nab@linux-iscsi.org>
> > Reviewed-by: Christoph Hellwig <hch@lst.de>
> 
> This is a major No-no: you can't actually add a reviewed by tag until
> the actual reviewer says so (and Christoph hasn't said so anywhere).
> Even if he had, and you think you've responded to all Christophs
> concerns, you still need to wait for him to look at the file and agree.
> 

Fair enough.  Chrisopth, are you happy with the code at this point..?

Thanks,

--nab