mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Eric Dumazet <eric.dumazet@gmail.com>
To: Tao Ma <tm@tao.ma>
Cc: linux-kernel@vger.kernel.org, Greg Kroah-Hartman <gregkh@suse.de>
Subject: Re: [PATCH] usb_wwan: fix build error in play_delayed.
Date: Tue, 22 Mar 2011 07:05:55 +0100	[thread overview]
Message-ID: <1300773955.2837.24.camel@edumazet-laptop> (raw)
In-Reply-To: <1300768162-18394-1-git-send-email-tm@tao.ma>

Le mardi 22 mars 2011 à 12:29 +0800, Tao Ma a écrit :
> From: Tao Ma <boyu.mt@taobao.com>
> 
> There is a build error in today's linus tree.
> drivers/usb/serial/usb_wwan.c: In function ‘play_delayed’:
> drivers/usb/serial/usb_wwan.c:702: error: ‘struct dev_pm_info’ has no member named ‘usage_count’
> The reason is that usage_count is wrapped with macro CONFIG_PM_RUNTIME
> now in dev_pm_info.
> 
> So use the corresponding pm_runtime_get_noresume instead.
> 
> Cc: Greg Kroah-Hartman <gregkh@suse.de>
> Signed-off-by: Tao Ma <boyu.mt@taobao.com>
> ---
>  drivers/usb/serial/usb_wwan.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/usb/serial/usb_wwan.c b/drivers/usb/serial/usb_wwan.c
> index a65ddd5..5858ce4 100644
> --- a/drivers/usb/serial/usb_wwan.c
> +++ b/drivers/usb/serial/usb_wwan.c
> @@ -699,7 +699,7 @@ static void play_delayed(struct usb_serial_port *port)
>  			do {
>  				unbusy_queued_urb(urb, portdata);
>  				//extremely dirty
> -				atomic_dec(&port->serial->interface->dev.power.usage_count);
> +				pm_runtime_get_noresume(&port->serial->interface->dev);
>  			} while ((urb = usb_get_from_anchor(&portdata->delayed)));
>  			break;
>  		}

Oh well, thats the third time this patch is sent



  reply	other threads:[~2011-03-22  6:06 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-22  4:29 Tao Ma
2011-03-22  6:05 ` Eric Dumazet [this message]
2011-03-22 16:44   ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1300773955.2837.24.camel@edumazet-laptop \
    --to=eric.dumazet@gmail.com \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tm@tao.ma \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®