From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756440Ab1CVRMG (ORCPT ); Tue, 22 Mar 2011 13:12:06 -0400 Received: from mgw2.diku.dk ([130.225.96.92]:60974 "EHLO mgw2.diku.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756393Ab1CVRMD (ORCPT ); Tue, 22 Mar 2011 13:12:03 -0400 From: Julia Lawall To: Chris Ball Cc: kernel-janitors@vger.kernel.org, Andrew Morton , "Martin K. Petersen" , Linus Walleij , Marek Vasut , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 3/3] drivers/mmc/host/pxamci.c: Convert release_resource to release_mem_region Date: Tue, 22 Mar 2011 18:14:55 +0100 Message-Id: <1300814095-25278-3-git-send-email-julia@diku.dk> X-Mailer: git-send-email 1.7.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Request_mem_region should be used with release_mem_region, not release_resource. A semantic patch that partially fixes this problem is as follows: (http://coccinelle.lip6.fr/) // @b@ expression x,E; @@ x = request_mem_region(x->start,...) ... when != release_mem_region(x->start,...) when != x = E ( - release_resource(x); - kfree(x); + release_mem_region(x->start,resource_size(x)); | ?- release_resource(x); + release_mem_region(x->start,resource_size(x)); ) // Signed-off-by: Julia Lawall --- drivers/mmc/host/pxamci.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/mmc/host/pxamci.c b/drivers/mmc/host/pxamci.c index 7257738..b6e7e64 100644 --- a/drivers/mmc/host/pxamci.c +++ b/drivers/mmc/host/pxamci.c @@ -774,7 +774,7 @@ err_gpio_ro: } if (mmc) mmc_free_host(mmc); - release_resource(r); + release_mem_region(r->start, resource_size(r)); return ret; } @@ -824,7 +824,7 @@ static int pxamci_remove(struct platform_device *pdev) clk_put(host->clk); - release_resource(host->res); + release_mem_region(host->res->start, resource_size(host->res)); mmc_free_host(mmc); }