mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: linux-kernel@vger.kernel.org, Ingo Molnar <mingo@elte.hu>,
	Andrew Morton <akpm@linux-foundation.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Lai Jiangshan <laijs@cn.fujitsu.com>,
	Darren Hart <dvhart@linux.intel.com>
Subject: Re: [PATCH 1/2 v2] WARN_ON_SMP(): Allow use in if statements on UP
Date: Thu, 24 Mar 2011 09:36:42 -0400	[thread overview]
Message-ID: <1300973802.14261.140.camel@gandalf.stny.rr.com> (raw)
In-Reply-To: <1300439538.21794.18.camel@twins>

On Fri, 2011-03-18 at 10:12 +0100, Peter Zijlstra wrote:
> On Thu, 2011-03-17 at 17:56 -0400, Steven Rostedt wrote:
> > + * WARN_ON(!spin_is_locked(&lock)) checks, as spin_is_locked()
> > + * returns 0 for uniprocessor settings. 
> 
> Arguably most spin_is_locked() usages should be removed in favour of
> something like lockdep_assert_held().
> 
> The latter only emits code then built with lockdep enabled and it checks
> we are indeed the owner, not some random other cpu.
> 

Without going into the issue that spin_is_locked() should go into the
lockdep category, and we should restructure every user of it to use
lockdep instead...

Peter, for the immediate fix (eg. this merge window), can I have your
acked-by for this patch?

Thanks,

-- Steve



  parent reply	other threads:[~2011-03-24 13:36 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-17 21:56 [PATCH 0/2 v2] [GIT PULL] futex: Fix WARN_ON trigging " Steven Rostedt
2011-03-17 21:56 ` [PATCH 1/2 v2] WARN_ON_SMP(): Allow use in if statements " Steven Rostedt
2011-03-18  9:12   ` Peter Zijlstra
2011-03-18 12:14     ` Steven Rostedt
2011-03-18 12:27       ` Peter Zijlstra
2011-03-24 13:36     ` Steven Rostedt [this message]
2011-03-17 21:56 ` [PATCH 2/2 v2] futex: Fix WARN_ON() test for UP Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1300973802.14261.140.camel@gandalf.stny.rr.com \
    --to=rostedt@goodmis.org \
    --cc=akpm@linux-foundation.org \
    --cc=dvhart@linux.intel.com \
    --cc=laijs@cn.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®