mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ralf Thielow <ralf.thielow@googlemail.com>
To: gregkh@suse.de
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
	Ralf Thielow <ralf.thielow@googlemail.com>
Subject: [PATCH 3/4] staging: keucr: smscsi: Removed commented declarations and statements.
Date: Sat, 26 Mar 2011 17:16:19 +0100	[thread overview]
Message-ID: <1301156180-12192-3-git-send-email-ralf.thielow@googlemail.com> (raw)
In-Reply-To: <1301156180-12192-1-git-send-email-ralf.thielow@googlemail.com>

Removed commented declarations and statements.

Signed-off-by: Ralf Thielow <ralf.thielow@googlemail.com>
---
 drivers/staging/keucr/smscsi.c |   25 -------------------------
 1 files changed, 0 insertions(+), 25 deletions(-)

diff --git a/drivers/staging/keucr/smscsi.c b/drivers/staging/keucr/smscsi.c
index 20386ce..f857be7 100644
--- a/drivers/staging/keucr/smscsi.c
+++ b/drivers/staging/keucr/smscsi.c
@@ -48,7 +48,6 @@ int SM_SCSIIrp(struct us_data *us, struct scsi_cmnd *srb)
 
 int SM_SCSI_Test_Unit_Ready(struct us_data *us, struct scsi_cmnd *srb)
 {
-	/* printk("SM_SCSI_Test_Unit_Ready\n"); */
 	if (us->SM_Status.Insert && us->SM_Status.Ready) {
 		return USB_STOR_TRANSPORT_GOOD;
 	} else {
@@ -61,7 +60,6 @@ int SM_SCSI_Test_Unit_Ready(struct us_data *us, struct scsi_cmnd *srb)
 
 int SM_SCSI_Inquiry(struct us_data *us, struct scsi_cmnd *srb)
 {
-	/* printk("SM_SCSI_Inquiry\n"); */
 	BYTE data_ptr[36] = {0x00, 0x80, 0x02, 0x00, 0x1F, 0x00,
 				0x00, 0x00, 0x55, 0x53, 0x42, 0x32,
 				0x2E, 0x30, 0x20, 0x20, 0x43, 0x61,
@@ -102,13 +100,6 @@ int SM_SCSI_Read_Capacity(struct us_data *us, struct scsi_cmnd *srb)
 	bl_len = 0x200;
 	bl_num = Ssfdc.MaxLogBlocks * Ssfdc.MaxSectors * Ssfdc.MaxZones - 1;
 
-	/*
-	 * printk("MaxLogBlocks = %x\n", Ssfdc.MaxLogBlocks);
-	 * printk("MaxSectors   = %x\n", Ssfdc.MaxSectors);
-	 * printk("MaxZones     = %x\n", Ssfdc.MaxZones);
-	 * printk("bl_num       = %x\n", bl_num);
-	 */
-
 	us->bl_num = bl_num;
 	printk(KERN_DEBUG, "bl_len = %x\n", bl_len);
 	printk(KERN_DEBUG, "bl_num = %x\n", bl_num);
@@ -123,17 +114,12 @@ int SM_SCSI_Read_Capacity(struct us_data *us, struct scsi_cmnd *srb)
 	buf[7] = (bl_len >> 0) & 0xff;
 
 	usb_stor_access_xfer_buf(us, buf, 8, srb, &sg, &offset, TO_XFER_BUF);
-	/*
-	 * usb_stor_set_xfer_buf(us, buf, srb->request_bufflen,
-	 *			srb, TO_XFER_BUF);
-	 */
 
 	return USB_STOR_TRANSPORT_GOOD;
 }
 
 int SM_SCSI_Read(struct us_data *us, struct scsi_cmnd *srb)
 {
-	/* struct bulk_cb_wrap *bcb = (struct bulk_cb_wrap *) us->iobuf; */
 	int result = 0;
 	PBYTE Cdb = srb->cmnd;
 	DWORD bn =
@@ -143,11 +129,6 @@ int SM_SCSI_Read(struct us_data *us, struct scsi_cmnd *srb)
 	DWORD blenByte = blen * 0x200;
 	void *buf;
 
-	/*
-	 * printk("SCSIOP_READ --- bn = %X, blen = %X, srb->use_sg = %X\n",
-	 *				bn, blen, srb->use_sg);
-	 */
-
 	if (bn > us->bl_num)
 		return USB_STOR_TRANSPORT_ERROR;
 
@@ -168,7 +149,6 @@ int SM_SCSI_Read(struct us_data *us, struct scsi_cmnd *srb)
 
 int SM_SCSI_Write(struct us_data *us, struct scsi_cmnd *srb)
 {
-	/* struct bulk_cb_wrap *bcb = (struct bulk_cb_wrap *) us->iobuf; */
 	int result = 0;
 	PBYTE Cdb = srb->cmnd;
 	DWORD bn =
@@ -178,11 +158,6 @@ int SM_SCSI_Write(struct us_data *us, struct scsi_cmnd *srb)
 	DWORD blenByte = blen * 0x200;
 	void *buf;
 
-	/*
-	 * printk("SCSIOP_Write --- bn = %X, blen = %X, srb->use_sg = %X\n",
-	 *				bn, blen, srb->use_sg);
-	 */
-
 	if (bn > us->bl_num)
 		return USB_STOR_TRANSPORT_ERROR;
 
-- 
1.7.4.1


  parent reply	other threads:[~2011-03-26 16:16 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-26 16:16 [PATCH 1/4] staging: keucr: smscsi: Fixed most checkpatch warnings and errors Ralf Thielow
2011-03-26 16:16 ` [PATCH 2/4] staging: keucr: smscsi: Includes missing KERN_ facility level to printk() Ralf Thielow
2011-03-26 18:51   ` Joe Perches
2011-03-26 19:11     ` Ralf Thielow
2011-03-26 19:26       ` Joe Perches
2011-03-26 19:33         ` Ralf Thielow
2011-03-26 16:16 ` Ralf Thielow [this message]
2011-03-26 16:16 ` [PATCH 4/4] staging: keucr: smscsi: Removed unreachable return statements Ralf Thielow

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1301156180-12192-3-git-send-email-ralf.thielow@googlemail.com \
    --to=ralf.thielow@googlemail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®