From: wni@nvidia.com
To: rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org,
a.zummo@towertech.it
Cc: linux-tegra@vger.kernel.org, Wei Ni <wni@nvidia.com>
Subject: [PATCH v9] mfd: tps6586x: add RTC driver for TI TPS6586x
Date: Mon, 28 Mar 2011 18:36:54 +0800 [thread overview]
Message-ID: <1301308615-6507-1-git-send-email-wni@nvidia.com> (raw)
From: Wei Ni <wni@nvidia.com>
this driver supports setting of alarms, and
reading/setting of time
Signed-off-by: Wei Ni <wni@nvidia.com>
---
v9: check the enable_irq_wake/disable_irq_wake return value.
fix these two function's fisrt paremeter, it should use "&pdev->dev"
drivers/rtc/rtc-tps6586x.c | 18 ++++++++++++++----
1 files changed, 14 insertions(+), 4 deletions(-)
diff --git a/drivers/rtc/rtc-tps6586x.c b/drivers/rtc/rtc-tps6586x.c
index b891899..a3944a5 100644
--- a/drivers/rtc/rtc-tps6586x.c
+++ b/drivers/rtc/rtc-tps6586x.c
@@ -335,19 +335,29 @@ static int __devexit tps6586x_rtc_remove(struct platform_device *pdev)
static int tps6586x_rtc_suspend(struct platform_device *pdev,
pm_message_t state)
{
+ int ret;
struct tps6586x_rtc *rtc = dev_get_drvdata(&pdev->dev);
- if (device_may_wakeup(pdev))
- enable_irq_wake(rtc->irq);
+ if (device_may_wakeup(&pdev->dev))
+ ret = enable_irq_wake(rtc->irq);
+
+ if (ret)
+ dev_warn(&pdev->dev, "enable irq wakeup failed.\n");
+
return 0;
}
static int tps6586x_rtc_resume(struct platform_device *pdev)
{
+ int ret;
struct tps6586x_rtc *rtc = dev_get_drvdata(&pdev->dev);
- if (device_may_wakeup(pdev))
- disable_irq_wake(rtc->irq);
+ if (device_may_wakeup(&pdev->dev))
+ ret = disable_irq_wake(rtc->irq);
+
+ if (ret)
+ dev_warn(&pdev->dev, "disable irq wakeup failed.\n");
+
return 0;
}
--
1.7.0
next reply other threads:[~2011-03-28 10:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-28 10:36 wni [this message]
2011-04-06 9:16 ` Wei Ni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1301308615-6507-1-git-send-email-wni@nvidia.com \
--to=wni@nvidia.com \
--cc=a.zummo@towertech.it \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=rtc-linux@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®