From: Peter Tyser <ptyser@xes-inc.com>
To: Tomoya MORINAGA <tomoya-linux@dsn.okisemi.com>
Cc: linux-kernel@vger.kernel.org, qi.wang@intel.com,
yong.y.wang@intel.com, joel.clark@intel.com,
kok.howg.ewe@intel.com, toshiharu-linux@dsn.okisemi.com
Subject: Re: [PATCH] pch_gpio: Fix output value of pch_gpio_direction_output()
Date: Wed, 30 Mar 2011 09:46:43 -0500 [thread overview]
Message-ID: <1301496403.24947.8543.camel@petert> (raw)
In-Reply-To: <1301487386-29101-1-git-send-email-tomoya-linux@dsn.okisemi.com>
On Wed, 2011-03-30 at 21:16 +0900, Tomoya MORINAGA wrote:
> The pch_gpio_direction_output() function was missing a write to set the
> desired output value. The function would properly set the GPIO
> direction, but not the output value. The value would have to manually
> be set with a follow up call to pch_gpio_set().
>
> Add the missing write so that pch_gpio_direction_output() sets both the
> GPIO direction and value.
>
> Reported-by: Peter Tyser <ptyser@xes-inc.com>
> Signed-off-by: Tomoya MORINAGA <tomoya-linux@dsn.okisemi.com>
Hi Tomoya,
I posted this same patch last week:
https://patchwork.kernel.org/patch/662621/
It looks like this driver and the ml_ioh_gpio driver are nearly
identical, hence the identical fixes. If you have some spare cycles
it'd be nice to combine them.
Best,
Peter
next prev parent reply other threads:[~2011-03-30 14:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-30 12:16 Tomoya MORINAGA
2011-03-30 14:46 ` Peter Tyser [this message]
2011-03-30 23:46 ` Tomoya MORINAGA
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1301496403.24947.8543.camel@petert \
--to=ptyser@xes-inc.com \
--cc=joel.clark@intel.com \
--cc=kok.howg.ewe@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=qi.wang@intel.com \
--cc=tomoya-linux@dsn.okisemi.com \
--cc=toshiharu-linux@dsn.okisemi.com \
--cc=yong.y.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome