From: Justin TerAvest <teravest@google.com>
To: vgoyal@redhat.com
Cc: jaxboe@fusionio.com, m-ikeda@ds.jp.nec.com, ryov@valinux.co.jp,
taka@valinux.co.jp, kamezawa.hiroyu@jp.fujitsu.com,
righi.andrea@gmail.com, guijianfeng@cn.fujitsu.com,
balbir@linux.vnet.ibm.com, ctalbott@google.com,
linux-kernel@vger.kernel.org,
Justin TerAvest <teravest@google.com>
Subject: [PATCH v3 8/8] cfq: Don't allow preemption across cgroups
Date: Wed, 30 Mar 2011 09:50:40 -0700 [thread overview]
Message-ID: <1301503840-25851-9-git-send-email-teravest@google.com> (raw)
In-Reply-To: <1301503840-25851-1-git-send-email-teravest@google.com>
Previously, a sync queue in can preempt an async queue in another
cgroup. This changes that behavior to disallow such preemption.
Signed-off-by: Justin TerAvest <teravest@google.com>
---
block/cfq-iosched.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/block/cfq-iosched.c b/block/cfq-iosched.c
index 23caa79..0d0189b 100644
--- a/block/cfq-iosched.c
+++ b/block/cfq-iosched.c
@@ -3430,6 +3430,9 @@ cfq_should_preempt(struct cfq_data *cfqd, struct cfq_queue *new_cfqq,
if (!cfqq)
return false;
+ if (new_cfqq->cfqg != cfqq->cfqg)
+ return false;
+
if (cfq_class_idle(new_cfqq))
return false;
@@ -3449,9 +3452,6 @@ cfq_should_preempt(struct cfq_data *cfqd, struct cfq_queue *new_cfqq,
if (rq_is_sync(rq) && !cfq_cfqq_sync(cfqq))
return true;
- if (new_cfqq->cfqg != cfqq->cfqg)
- return false;
-
if (cfq_slice_used(cfqq))
return true;
--
1.7.3.1
prev parent reply other threads:[~2011-03-30 16:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-30 16:50 [RFC] [PATCH v3 0/8] Provide cgroup isolation for buffered writes Justin TerAvest
2011-03-30 16:50 ` [PATCH v3 1/8] cfq-iosched: add symmetric reference wrappers Justin TerAvest
2011-03-30 16:50 ` [PATCH v3 2/8] block,fs,mm: IO cgroup tracking for buffered write Justin TerAvest
2011-03-30 16:50 ` [PATCH v3 3/8] cfq-iosched: Make async queues per cgroup Justin TerAvest
2011-03-30 16:50 ` [PATCH v3 4/8] block: Modify CFQ to use IO tracking information Justin TerAvest
2011-03-30 16:50 ` [PATCH v3 5/8] cfq: Fix up tracked async workload length Justin TerAvest
2011-03-30 16:50 ` [PATCH v3 6/8] cfq: add per cgroup writeout done by flusher stat Justin TerAvest
2011-03-30 16:50 ` [PATCH v3 7/8] block: Per cgroup request descriptor counts Justin TerAvest
2011-03-30 16:50 ` Justin TerAvest [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1301503840-25851-9-git-send-email-teravest@google.com \
--to=teravest@google.com \
--cc=balbir@linux.vnet.ibm.com \
--cc=ctalbott@google.com \
--cc=guijianfeng@cn.fujitsu.com \
--cc=jaxboe@fusionio.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=m-ikeda@ds.jp.nec.com \
--cc=righi.andrea@gmail.com \
--cc=ryov@valinux.co.jp \
--cc=taka@valinux.co.jp \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®