From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757278Ab1DAOZX (ORCPT ); Fri, 1 Apr 2011 10:25:23 -0400 Received: from mgw2.diku.dk ([130.225.96.92]:35635 "EHLO mgw2.diku.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754722Ab1DAOX5 (ORCPT ); Fri, 1 Apr 2011 10:23:57 -0400 From: Julia Lawall To: Greg Kroah-Hartman Cc: kernel-janitors@vger.kernel.org, Mauro Carvalho Chehab , Hans Verkuil , Palash Bandyopadhyay , Andreas Bombe , Joe Perches , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH 3/6] drivers/staging/cx25821/cx25821-video.c: introduce missing kfree Date: Fri, 1 Apr 2011 16:23:44 +0200 Message-Id: <1301667827-20056-3-git-send-email-julia@diku.dk> X-Mailer: git-send-email 1.7.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Error handling code following a kmalloc should free the allocated data. The semantic match that finds the problem is as follows: (http://www.emn.fr/x-info/coccinelle/) // @r exists@ local idexpression x; statement S; expression E; identifier f,f1,l; position p1,p2; expression *ptr != NULL; @@ x@p1 = \(kmalloc\|kzalloc\|kcalloc\)(...); ... if (x == NULL) S <... when != x when != if (...) { <+...x...+> } ( x->f1 = E | (x->f1 == NULL || ...) | f(...,x->f1,...) ) ...> ( return \(0\|<+...x...+>\|ptr\); | return@p2 ...; ) @script:python@ p1 << r.p1; p2 << r.p2; @@ print "* file: %s kmalloc %s return %s" % (p1[0].file,p1[0].line,p2[0].line) // Signed-off-by: Julia Lawall --- drivers/staging/cx25821/cx25821-video.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/cx25821/cx25821-video.c b/drivers/staging/cx25821/cx25821-video.c index ab05392..04b18f4 100644 --- a/drivers/staging/cx25821/cx25821-video.c +++ b/drivers/staging/cx25821/cx25821-video.c @@ -832,6 +832,7 @@ static int video_open(struct file *file) if (NULL == dev) { mutex_unlock(&cx25821_devlist_mutex); + kfree(fh); return -ENODEV; }