From: Florian Mickler <florian@mickler.org>
To: mchehab@infradead.org
Cc: oliver@neukum.org, linux-kernel@vger.kernel.org,
linux-media@vger.kernel.org, patrick.boettcher@dibcom.fr
Subject: [media] dib0700: get rid of on-stack dma buffers
Date: Sun, 3 Apr 2011 19:23:41 +0200 [thread overview]
Message-ID: <1301851423-21969-1-git-send-email-florian@mickler.org> (raw)
Hi,
since I got no reaction[1] on the vp702x driver, I proceed with the
dib0700.
There are multiple drivers in drivers/media/dvb/dvb-usb/ which use
usb_control_msg to perform dma to stack-allocated buffers. This is a bad idea
because of cache-coherency issues and on some platforms the stack is mapped
virtually and also lib/dma-debug.c warn's about it at runtime.
Patches to ec168, ce6230, au6610 and lmedm04 were already tested and reviewed
and submitted for inclusion [2]. Patches to a800, vp7045, friio, dw2102, m920x
and opera1 are still waiting for for review and testing [3].
This patch to dib0700 is a fix for a warning seen and reported by Zdenek
Kabalec in Bug #15977 [4].
Florian Mickler (2):
[media] dib0700: get rid of on-stack dma buffers
[media] dib0700: remove unused variable
Regards,
Flo
References:
[1]: http://www.spinics.net/lists/linux-media/msg30448.html
[2]: http://comments.gmane.org/gmane.linux.kernel/1115404
[3]: http://groups.google.com/group/fa.linux.kernel/browse_frm/thread/e169edc121b91181/f1498cd026a59fe2
[4]: https://bugzilla.kernel.org/show_bug.cgi?id=15977
next reply other threads:[~2011-04-03 17:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-03 17:23 Florian Mickler [this message]
2011-04-03 17:23 ` [PATCH 1/2] " Florian Mickler
2011-04-03 17:23 ` [PATCH 2/2] [media] dib0700: remove unused variable Florian Mickler
2011-04-04 7:42 ` [media] dib0700: get rid of on-stack dma buffers Patrick Boettcher
2011-04-04 16:20 ` Florian Mickler
2011-04-04 19:34 ` Florian Mickler
2011-04-29 21:32 ` Mauro Carvalho Chehab
2011-04-30 9:46 ` Florian Mickler
2011-04-30 12:50 ` Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1301851423-21969-1-git-send-email-florian@mickler.org \
--to=florian@mickler.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@infradead.org \
--cc=oliver@neukum.org \
--cc=patrick.boettcher@dibcom.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®