mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Michal Simek <monstr@monstr.eu>
To: linux-kernel@vger.kernel.org
Cc: john.williams@petalogix.com
Subject: Microblaze early console support
Date: Mon,  4 Apr 2011 18:30:54 +0200	[thread overview]
Message-ID: <1301934655-20495-1-git-send-email-monstr@monstr.eu> (raw)

Hi,

I have one question about early console support on MMU kernel.
When do you register an early console and what TLB mapping you use?

For Microblaze I registered it before main memory is setup that's why I was
hardcoded TLB 63 to 1:1 mapping (virt addr = phys addr). 
It is output only for early_printk messages but I would like to use it 
as boot console. There are only some messages that's why TLB 63 was released
later on.
That is the current state.

I have added CON_BOOT flag and register early console by register_console function
and I allocate TLB 63 for it. But unfortunately I haven't found any function 
in unregister_console which is called for unregistering to help me to release TLB 63
when early console is not used. Is there any way how to do it?

>From our experiment in past there is performance degression when kernel can't use
a TLB that's why I tried to find out a way to release TLB 63.
This is the reason why I would like to know your opinion if my style is correct 
or not.
I created new remap_early_printk function which does ioremap for console space.
This function is called from setup_arch when memory is setup. Then early mapping of TLB 63
is automatically released and can be used for Linux purpose.
Is it correct design how to do it?

How do you handle it in your arch? Do you register early console before memory initialization
is done?

You can also look at my patch I have done.

Thanks for your suggestions,
Michal



             reply	other threads:[~2011-04-04 16:31 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-04 16:30 Michal Simek [this message]
2011-04-04 16:30 ` [PATCH] microblaze: Get early printk console earlier Michal Simek
2011-04-04 17:21 ` Microblaze early console support Michal Simek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1301934655-20495-1-git-send-email-monstr@monstr.eu \
    --to=monstr@monstr.eu \
    --cc=john.williams@petalogix.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®