From: Ilkka Koskinen <ilkka.koskinen@nokia.com>
To: eric.piel@tremplin-utc.net, mjg@redhat.com
Cc: linux-kernel@vger.kernel.org,
platform-driver-x86@vger.kernel.org, samu.p.onkalo@nokia.com,
ilkka.koskinen@nokia.com
Subject: [RFC PATCHv2 1/5] hwmon: lis3: Free regulators if probe() fails.
Date: Tue, 5 Apr 2011 17:45:10 +0300 [thread overview]
Message-ID: <1302014714-7334-2-git-send-email-ilkka.koskinen@nokia.com> (raw)
In-Reply-To: <1302014714-7334-1-git-send-email-ilkka.koskinen@nokia.com>
Signed-off-by: Ilkka Koskinen <ilkka.koskinen@nokia.com>
---
drivers/misc/lis3lv02d/lis3lv02d_i2c.c | 9 +++++++--
1 files changed, 7 insertions(+), 2 deletions(-)
diff --git a/drivers/misc/lis3lv02d/lis3lv02d_i2c.c b/drivers/misc/lis3lv02d/lis3lv02d_i2c.c
index b20dfb4..ea9159c 100644
--- a/drivers/misc/lis3lv02d/lis3lv02d_i2c.c
+++ b/drivers/misc/lis3lv02d/lis3lv02d_i2c.c
@@ -161,8 +161,13 @@ static int __devinit lis3lv02d_i2c_probe(struct i2c_client *client,
if (lis3_dev.reg_ctrl)
lis3_reg_ctrl(&lis3_dev, LIS3_REG_OFF);
- if (ret == 0)
- return 0;
+ if (ret)
+ goto fail2;
+ return 0;
+
+fail2:
+ regulator_bulk_free(ARRAY_SIZE(lis3_dev.regulators),
+ lis3_dev.regulators);
fail:
if (pdata && pdata->release_resources)
pdata->release_resources();
--
1.7.0.4
next prev parent reply other threads:[~2011-04-05 14:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-05 14:45 [RFC PATCHv2 0/5] lis3lv02d: Regulator fix & support for multiple devices Ilkka Koskinen
2011-04-05 14:45 ` Ilkka Koskinen [this message]
2011-04-05 14:45 ` [RFC PATCHv2 2/5] hwmon: lis3: Change naming to consistent Ilkka Koskinen
2011-04-05 14:45 ` [RFC PATCHv2 3/5] hwmon: lis3: Change exported function to use given device Ilkka Koskinen
2011-04-05 14:45 ` [RFC PATCHv2 4/5] hwmon: lis3: Remove the referencies to the global variable in core driver Ilkka Koskinen
2011-04-05 15:50 ` Thadeu Lima de Souza Cascardo
2011-04-07 11:59 ` Ilkka Koskinen
2011-04-07 21:58 ` Thadeu Lima de Souza Cascardo
2011-04-08 17:51 ` Jonathan Cameron
2011-04-05 14:45 ` [RFC PATCHv2 5/5] hwmon: lis3: Register hwif and remove references to global variable Ilkka Koskinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1302014714-7334-2-git-send-email-ilkka.koskinen@nokia.com \
--to=ilkka.koskinen@nokia.com \
--cc=eric.piel@tremplin-utc.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mjg@redhat.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=samu.p.onkalo@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®