From: "Koul, Vinod" <vinod.koul@intel.com>
To: Liu Yuan <namei.unix@gmail.com>
Cc: Dan Williams <dan.j.williams@intel.com>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] drivers, pch_dma: Fix uninitialized var before use
Date: Wed, 06 Apr 2011 14:15:13 +0530 [thread overview]
Message-ID: <1302079513.18522.30.camel@vkoul-udesk3> (raw)
In-Reply-To: <1301725248-5102-1-git-send-email-namei.unix@gmail.com>
On Sat, 2011-04-02 at 14:20 +0800, Liu Yuan wrote:
> From: Liu Yuan <tailai.ly@taobao.com>
>
> In the function pdc_desc_get(), var 'i' is not
> initialized before use. This patch fixes it.
>
> Signed-off-by: Liu Yuan <tailai.ly@taobao.com>
> ---
> drivers/dma/pch_dma.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/dma/pch_dma.c b/drivers/dma/pch_dma.c
> index 8d8fef1..6eebc62 100644
> --- a/drivers/dma/pch_dma.c
> +++ b/drivers/dma/pch_dma.c
> @@ -403,7 +403,7 @@ static struct pch_dma_desc *pdc_desc_get(struct pch_dma_chan *pd_chan)
> {
> struct pch_dma_desc *desc, *_d;
> struct pch_dma_desc *ret = NULL;
> - int i;
> + int i = 0;
>
> spin_lock(&pd_chan->lock);
> list_for_each_entry_safe(desc, _d, &pd_chan->free_list, desc_node) {
Applied, Thanks
--
~Vinod
prev parent reply other threads:[~2011-04-06 9:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-02 6:20 Liu Yuan
2011-04-06 8:45 ` Koul, Vinod [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1302079513.18522.30.camel@vkoul-udesk3 \
--to=vinod.koul@intel.com \
--cc=dan.j.williams@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=namei.unix@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®