mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jamie Iles <jamie@jamieiles.com>
To: linux-kernel@vger.kernel.org
Cc: linux@arm.linux.org.uk, tglx@linutronix.de,
	cbouatmailru@gmail.com, grant.likely@secretlab.ca, arnd@arndb.de,
	nico@fluxnic.net, Jamie Iles <jamie@jamieiles.com>
Subject: [RFC PATCH 3/7] basic_mmio_gpio: allow overriding number of gpio
Date: Wed,  6 Apr 2011 12:10:59 +0100	[thread overview]
Message-ID: <1302088263-12714-4-git-send-email-jamie@jamieiles.com> (raw)
In-Reply-To: <1302088263-12714-1-git-send-email-jamie@jamieiles.com>

Some platforms may have a number of GPIO that is less than the register
width of the peripheral.

Signed-off-by: Jamie Iles <jamie@jamieiles.com>
Cc: Anton Vorontsov <cbouatmailru@gmail.com>
Cc: Grant Likely <grant.likely@secretlab.ca>
---
 drivers/gpio/basic_mmio_gpio.c  |   17 +++++++++++------
 include/linux/basic_mmio_gpio.h |    1 +
 2 files changed, 12 insertions(+), 6 deletions(-)

diff --git a/drivers/gpio/basic_mmio_gpio.c b/drivers/gpio/basic_mmio_gpio.c
index e6cce48..68f8b8b 100644
--- a/drivers/gpio/basic_mmio_gpio.c
+++ b/drivers/gpio/basic_mmio_gpio.c
@@ -240,6 +240,7 @@ static int __devinit bgpio_probe(struct platform_device *pdev)
 	resource_size_t dat_sz;
 	int bits;
 	int ret;
+	int ngpio;
 
 	res_dat = platform_get_resource_byname(pdev, IORESOURCE_MEM, "dat");
 	if (!res_dat)
@@ -250,6 +251,7 @@ static int __devinit bgpio_probe(struct platform_device *pdev)
 		return -EINVAL;
 
 	bits = dat_sz * 8;
+	ngpio = bits;
 	if (bits > BITS_PER_LONG)
 		return -EINVAL;
 
@@ -276,6 +278,13 @@ static int __devinit bgpio_probe(struct platform_device *pdev)
 		return -EINVAL;
 	}
 
+	if (pdata) {
+		bgc->gc.base = pdata->base;
+		if (pdata->ngpio > 0)
+			ngpio = pdata->ngpio;
+	} else
+		bgc->gc.base = -1;
+
 	bgc->bits = bits;
 	ret = bgpio_setup_accessors(pdev, bgc);
 	if (ret)
@@ -283,7 +292,8 @@ static int __devinit bgpio_probe(struct platform_device *pdev)
 
 	spin_lock_init(&bgc->lock);
 	bgc->data = bgc->read_reg(bgc->reg_dat);
-	bgc->gc.ngpio = bits;
+
+	bgc->gc.ngpio = ngpio;
 	bgc->gc.direction_input = bgpio_dir_in;
 	bgc->gc.direction_output = bgpio_dir_out;
 	bgc->gc.get = bgpio_get;
@@ -291,11 +301,6 @@ static int __devinit bgpio_probe(struct platform_device *pdev)
 	bgc->gc.dev = dev;
 	bgc->gc.label = dev_name(dev);
 
-	if (pdata)
-		bgc->gc.base = pdata->base;
-	else
-		bgc->gc.base = -1;
-
 	platform_set_drvdata(pdev, bgc);
 
 	ret = gpiochip_add(&bgc->gc);
diff --git a/include/linux/basic_mmio_gpio.h b/include/linux/basic_mmio_gpio.h
index 198087a..f23ec73 100644
--- a/include/linux/basic_mmio_gpio.h
+++ b/include/linux/basic_mmio_gpio.h
@@ -15,6 +15,7 @@
 
 struct bgpio_pdata {
 	int base;
+	int ngpio;
 };
 
 #endif /* __BASIC_MMIO_GPIO_H */
-- 
1.7.4


  parent reply	other threads:[~2011-04-06 11:11 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-06 11:10 [RFC PATCH 0/7] gpio: extend basic_mmio_gpio for different controllers Jamie Iles
2011-04-06 11:10 ` [RFC PATCH 1/7] basic_mmio_gpio: remove runtime width/endianness evaluation Jamie Iles
2011-04-06 12:12   ` Anton Vorontsov
2011-04-06 11:10 ` [RFC PATCH 2/7] basic_mmio_gpio: convert to platform_{get,set}_drvdata() Jamie Iles
2011-04-06 12:16   ` Anton Vorontsov
2011-04-06 11:10 ` Jamie Iles [this message]
2011-04-06 12:18   ` [RFC PATCH 3/7] basic_mmio_gpio: allow overriding number of gpio Anton Vorontsov
2011-04-06 11:11 ` [RFC PATCH 4/7] basic_mmio_gpio: request register regions Jamie Iles
2011-04-06 12:32   ` Anton Vorontsov
2011-04-06 11:11 ` [RFC PATCH 5/7] basic_mmio_gpio: detect output method at probe time Jamie Iles
2011-04-06 12:33   ` Anton Vorontsov
2011-04-06 11:11 ` [RFC PATCH 6/7] basic_mmio_gpio: support different input/output registers Jamie Iles
2011-04-06 12:16   ` Anton Vorontsov
2011-04-06 11:11 ` [RFC PATCH 7/7] basic_mmio_gpio: support direction registers Jamie Iles
2011-04-06 12:12   ` Anton Vorontsov
2011-04-08  0:14     ` Jamie Iles

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1302088263-12714-4-git-send-email-jamie@jamieiles.com \
    --to=jamie@jamieiles.com \
    --cc=arnd@arndb.de \
    --cc=cbouatmailru@gmail.com \
    --cc=grant.likely@secretlab.ca \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=nico@fluxnic.net \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®