From: Eric Paris <eparis@redhat.com>
To: Paul Bolle <pebolle@tiscali.nl>
Cc: Stephen Smalley <sds@tycho.nsa.gov>,
James Morris <jmorris@namei.org>,
Eric Paris <eparis@parisplace.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] selinux: downgrade two printks to KERN_DEBUG
Date: Fri, 08 Apr 2011 09:00:20 -0400 [thread overview]
Message-ID: <1302267622.3937.3.camel@localhost.localdomain> (raw)
In-Reply-To: <1302253422.7787.2.camel@t41.thuisdomein>
They shouldn't be there at all and it was a big screw up on my part that
they were left in the committed code. I already applied but haven't
sent or pushed a patch to remove these. Thanks Paul!
-Eric
On Fri, 2011-04-08 at 11:03 +0200, Paul Bolle wrote:
> A recent (Fedora Rawhide) selinux policy update triggers this error:
> filename_trans_read: nel=0
>
> But there seems to be no reason why filename_trans_read() prints this
> message (and a similar message) at KERN_ERR level. So downgrade it to
> KERN_DEBUG level.
>
> Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
> ---
> Compile tested only.
>
> security/selinux/ss/policydb.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/security/selinux/ss/policydb.c b/security/selinux/ss/policydb.c
> index e7b850a..8e9cc8d10 100644
> --- a/security/selinux/ss/policydb.c
> +++ b/security/selinux/ss/policydb.c
> @@ -1819,7 +1819,7 @@ static int filename_trans_read(struct policydb *p, void *fp)
> goto out;
> nel = le32_to_cpu(buf[0]);
>
> - printk(KERN_ERR "%s: nel=%d\n", __func__, nel);
> + printk(KERN_DEBUG "%s: nel=%d\n", __func__, nel);
>
> last = p->filename_trans;
> while (last && last->next)
> @@ -1857,7 +1857,7 @@ static int filename_trans_read(struct policydb *p, void *fp)
> goto out;
> name[len] = 0;
>
> - printk(KERN_ERR "%s: ft=%p ft->name=%p ft->name=%s\n", __func__, ft, ft->name, ft->name);
> + printk(KERN_DEBUG "%s: ft=%p ft->name=%p ft->name=%s\n", __func__, ft, ft->name, ft->name);
>
> rc = next_entry(buf, fp, sizeof(u32) * 4);
> if (rc)
next prev parent reply other threads:[~2011-04-08 13:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-08 9:03 Paul Bolle
2011-04-08 13:00 ` Eric Paris [this message]
2011-05-08 10:46 ` Paul Bolle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1302267622.3937.3.camel@localhost.localdomain \
--to=eparis@redhat.com \
--cc=eparis@parisplace.org \
--cc=jmorris@namei.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pebolle@tiscali.nl \
--cc=sds@tycho.nsa.gov \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®