From: Shaohua Li <shaohua.li@intel.com>
To: Christoph Lameter <cl@linux.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"tj@kernel.org" <tj@kernel.org>,
"eric.dumazet@gmail.com" <eric.dumazet@gmail.com>
Subject: Re: [patch v2 0/4] percpu_counter: cleanup and fix
Date: Thu, 14 Apr 2011 09:04:13 +0800 [thread overview]
Message-ID: <1302743053.3981.178.camel@sli10-conroe> (raw)
In-Reply-To: <alpine.DEB.2.00.1104130907480.16214@router.home>
On Wed, 2011-04-13 at 22:08 +0800, Christoph Lameter wrote:
> On Wed, 13 Apr 2011, shaohua.li@intel.com wrote:
>
> > Cleanup percpu_counter code and fix some bugs. The main purpose is to convert
> > percpu_counter to use atomic64, which is useful for workloads which cause
> > percpu_counter->lock contented. In a workload I tested, the atomic method is
> > 50x faster (please see patch 4 for detail).
>
> Could you post your test and the results please?
the test is very simple, 24 processes in 24 CPU, and each does:
while (1) {
mmap(128M);
munmap(128M)
}
we then measure how many loops the process can do.
I'll attach the test in next post.
Just found when I said 50x faster, I actually forgot one other patch's
effect, which is http://marc.info/?l=linux-kernel&m=130127782901127&w=2.
If only having the atomic change, it's about 7x faster. Sorry about
this. I'll add detail data in next post.
prev parent reply other threads:[~2011-04-14 1:04 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-13 7:57 shaohua.li
2011-04-13 7:57 ` [patch v2 1/4] percpu_counter: change return value and add comments shaohua.li
2011-04-13 19:05 ` Tejun Heo
2011-04-13 7:57 ` [patch v2 2/4] percpu_counter: delete dead code shaohua.li
2011-04-13 18:59 ` Tejun Heo
2011-04-18 0:12 ` Ted Ts'o
2011-04-13 7:57 ` [patch v2 3/4] percpu_counter: fix code for 32bit systems shaohua.li
2011-04-13 19:04 ` Tejun Heo
2011-04-13 7:57 ` [patch v2 4/4] percpu_counter: use atomic64 for counter shaohua.li
2011-04-13 19:07 ` Tejun Heo
2011-04-13 14:08 ` [patch v2 0/4] percpu_counter: cleanup and fix Christoph Lameter
2011-04-14 1:04 ` Shaohua Li [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1302743053.3981.178.camel@sli10-conroe \
--to=shaohua.li@intel.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=eric.dumazet@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®