From: Eric Dumazet <eric.dumazet@gmail.com>
To: Shaohua Li <shaohua.li@intel.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"tj@kernel.org" <tj@kernel.org>, "cl@linux.com" <cl@linux.com>
Subject: Re: [patch v3 2/3] percpu_counter: fix code for 32bit systems for UP
Date: Thu, 14 Apr 2011 04:54:37 +0200 [thread overview]
Message-ID: <1302749677.3549.26.camel@edumazet-laptop> (raw)
In-Reply-To: <1302749044.3981.183.camel@sli10-conroe>
Le jeudi 14 avril 2011 à 10:44 +0800, Shaohua Li a écrit :
> that's true. I just want the code looks consistent and this doesn't
> really obfuscate the code to me.
Doing so gives a false sense of security to user.
percpu_counter_init() is unsafe by nature.
next prev parent reply other threads:[~2011-04-14 2:54 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-14 2:04 [patch v3 0/3] percpu_counter: cleanup and fix shaohua.li
2011-04-14 2:04 ` [patch v3 1/3] percpu_counter: change return value and add comments shaohua.li
2011-04-14 2:32 ` Eric Dumazet
2011-04-15 3:41 ` Tejun Heo
2011-04-14 2:04 ` [patch v3 2/3] percpu_counter: fix code for 32bit systems for UP shaohua.li
2011-04-14 2:35 ` Eric Dumazet
2011-04-14 2:44 ` Shaohua Li
2011-04-14 2:54 ` Eric Dumazet [this message]
2011-04-18 7:41 ` Shaohua Li
2011-04-14 2:04 ` [patch v3 3/3] percpu_counter: use atomic64 for counter in SMP shaohua.li
2011-04-15 4:15 ` Tejun Heo
2011-04-18 7:43 ` Shaohua Li
2011-04-18 14:25 ` Christoph Lameter
2011-04-20 1:04 ` Shaohua Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1302749677.3549.26.camel@edumazet-laptop \
--to=eric.dumazet@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=shaohua.li@intel.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®