mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Joerg Roedel <joerg.roedel@amd.com>
To: Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
	Thomas Gleixner <tglx@linutronix.de>
Cc: <x86@kernel.org>, <linux-kernel@vger.kernel.org>,
	Joerg Roedel <joerg.roedel@amd.com>, <stable@kernel.org>,
	Borislav Petkov <borislav.petkov@amd.com>
Subject: [PATCH 3/4] x86, gart: Set DISTLBWALKPRB bit always
Date: Mon, 18 Apr 2011 15:45:45 +0200	[thread overview]
Message-ID: <1303134346-5805-4-git-send-email-joerg.roedel@amd.com> (raw)
In-Reply-To: <1303134346-5805-1-git-send-email-joerg.roedel@amd.com>

The DISTLBWALKPRB bit must be set for the GART because the
gatt table is mapped UC. But the current code does not set
the bit at boot when the BIOS setup the aperture correctly.
Fix that by setting this bit when enabling the GART instead
of the other places.

Cc: stable@kernel.org
Cc: Borislav Petkov <borislav.petkov@amd.com>
Signed-off-by: Joerg Roedel <joerg.roedel@amd.com>
---
 arch/x86/include/asm/gart.h   |    4 ++--
 arch/x86/kernel/aperture_64.c |    2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/x86/include/asm/gart.h b/arch/x86/include/asm/gart.h
index 88c1ebe..156cd5d 100644
--- a/arch/x86/include/asm/gart.h
+++ b/arch/x86/include/asm/gart.h
@@ -66,7 +66,7 @@ static inline void gart_set_size_and_enable(struct pci_dev *dev, u32 order)
 	 * Don't enable translation but enable GART IO and CPU accesses.
 	 * Also, set DISTLBWALKPRB since GART tables memory is UC.
 	 */
-	ctl = DISTLBWALKPRB | order << 1;
+	ctl = order << 1;
 
 	pci_write_config_dword(dev, AMD64_GARTAPERTURECTL, ctl);
 }
@@ -83,7 +83,7 @@ static inline void enable_gart_translation(struct pci_dev *dev, u64 addr)
 
 	/* Enable GART translation for this hammer. */
 	pci_read_config_dword(dev, AMD64_GARTAPERTURECTL, &ctl);
-	ctl |= GARTEN;
+	ctl |= GARTEN | DISTLBWALKPRB;
 	ctl &= ~(DISGARTCPU | DISGARTIO);
 	pci_write_config_dword(dev, AMD64_GARTAPERTURECTL, ctl);
 }
diff --git a/arch/x86/kernel/aperture_64.c b/arch/x86/kernel/aperture_64.c
index 5c66a2f..3d2661c 100644
--- a/arch/x86/kernel/aperture_64.c
+++ b/arch/x86/kernel/aperture_64.c
@@ -503,7 +503,7 @@ out:
 		 * Don't enable translation yet but enable GART IO and CPU
 		 * accesses and set DISTLBWALKPRB since GART table memory is UC.
 		 */
-		u32 ctl = DISTLBWALKPRB | aper_order << 1;
+		u32 ctl = aper_order << 1;
 
 		bus = amd_nb_bus_dev_ranges[i].bus;
 		dev_base = amd_nb_bus_dev_ranges[i].dev_base;
-- 
1.7.1



  parent reply	other threads:[~2011-04-18 13:46 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-18 13:45 [PATCH 0/4] gart cleanups and fixes Joerg Roedel
2011-04-18 13:45 ` [PATCH 1/4] x86, gart: Don't enforce GART aperture lower-bound by alignment Joerg Roedel
2011-04-18 14:45   ` H. Peter Anvin
2011-04-18 14:56     ` Roedel, Joerg
2011-04-18 15:51       ` H. Peter Anvin
2011-04-18 17:36         ` Joerg Roedel
2011-04-18 17:39           ` H. Peter Anvin
2011-04-18 17:50             ` Joerg Roedel
2011-04-18 19:06             ` Joerg Roedel
2011-04-18 19:40               ` H. Peter Anvin
2011-04-18 18:29   ` Yinghai Lu
2011-04-18 18:39   ` [tip:x86/gart] " tip-bot for Joerg Roedel
2011-04-18 13:45 ` [PATCH 2/4] x86, gart: Convert spaces to tabs in enable_gart_translation Joerg Roedel
2011-04-18 16:39   ` [tip:x86/urgent] " tip-bot for Joerg Roedel
2011-04-18 13:45 ` Joerg Roedel [this message]
2011-04-18 16:40   ` [tip:x86/urgent] x86, gart: Set DISTLBWALKPRB bit always tip-bot for Joerg Roedel
2011-04-18 13:45 ` [PATCH 4/4] x86, gart: Make sure GART does not map physmem above 1TB Joerg Roedel
2011-04-18 14:46   ` H. Peter Anvin
2011-04-18 14:52     ` Roedel, Joerg
2011-04-18 15:53       ` H. Peter Anvin
2011-04-18 14:54     ` H. Peter Anvin
2011-04-18 14:59       ` Roedel, Joerg
2011-04-18 15:50         ` Ingo Molnar
2011-04-19  6:12           ` Roedel, Joerg
2011-04-19  7:25             ` Ingo Molnar
2011-04-19  9:15               ` [PATCH] x86, gart: Rename pci-gart_64.c to amd64_gart.c Roedel, Joerg
2011-04-19 13:43               ` [PATCH 4/4] x86, gart: Make sure GART does not map physmem above 1TB H. Peter Anvin
2011-04-19 14:29                 ` Roedel, Joerg
2011-04-20 17:38                   ` H. Peter Anvin
2011-05-10 15:32                     ` [PATCH] x86, gart: Rename pci-gart_64.c to amd_gart_64.c 1TB Roedel, Joerg
2011-04-18 16:40   ` [tip:x86/urgent] x86, gart: Make sure GART does not map physmem above 1TB tip-bot for Joerg Roedel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1303134346-5805-4-git-send-email-joerg.roedel@amd.com \
    --to=joerg.roedel@amd.com \
    --cc=borislav.petkov@amd.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=stable@kernel.org \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome