From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Michal Hocko <mhocko@suse.cz>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Hugh Dickins <hughd@google.com>,
linux-mm@kvack.org, LKML <linux-kernel@vger.kernel.org>,
linux-parisc@vger.kernel.org
Subject: Re: [PATCH v3] mm: make expand_downwards symmetrical to expand_upwards
Date: Tue, 19 Apr 2011 10:46:49 -0500 [thread overview]
Message-ID: <1303228009.3171.18.camel@mulgrave.site> (raw)
In-Reply-To: <20110419111004.GE21689@tiehlicka.suse.cz>
On Tue, 2011-04-19 at 13:10 +0200, Michal Hocko wrote:
> On Mon 18-04-11 13:56:37, Andrew Morton wrote:
> > On Mon, 18 Apr 2011 12:01:31 +0200
> > Michal Hocko <mhocko@suse.cz> wrote:
> >
> > > Currently we have expand_upwards exported while expand_downwards is
> > > accessible only via expand_stack or expand_stack_downwards.
> > >
> > > check_stack_guard_page is a nice example of the asymmetry. It uses
> > > expand_stack for VM_GROWSDOWN while expand_upwards is called for
> > > VM_GROWSUP case.
> > >
> > > Let's clean this up by exporting both functions and make those name
> > > consistent. Let's use expand_stack_{upwards,downwards} so that we are
> > > explicit about stack manipulation in the name. expand_stack_downwards
> > > has to be defined for both CONFIG_STACK_GROWS{UP,DOWN} because
> > > get_arg_page calls the downwards version in the early process
> > > initialization phase for growsup configuration.
> >
> > Has this patch been tested on any stack-grows-upwards architecture?
>
> The only one I can find in the tree is parisc and I do not have access
> to any such machine. Maybe someone on the list (CCed) can help with
> testing the patch bellow? Nevertheless, the patch doesn't change growsup
> case. It just renames functions and exports growsdown.
It compiles OK, but crashes on boot in fsck. The crash is definitely mm
but looks to be a slab problem (it's a null deref on a spinlock in
add_partial(), which seems unrelated to this patch).
[ 15.628000] sd 1:0:2:0: [sdc] Attached SCSI disk
done.
[ 16.632000] EXT3-fs: barriers not enabled
[ 16.640000] kjournald starting. Commit interval 5 seconds
[ 16.640000] EXT3-fs (sda3): mounted filesystem with ordered data mode
Begin: Running /scripts/local-bottom ... done.
done.
Begin: Running /scripts/init-bottom ... done.
INIT: version 2.88 booting
Setting hostname to 'ion'...done.
Starting the hotplug events dispatcher: udevd[ 22.008000] udev[211]: starting version 164
.
Synthesizing the initial hotplug events...done.
Waiting for /dev to be fully populated...done.
Activating swap:swapon on /dev/sda2
swapon: /dev/sda2: found swap signature: version 1, page-size 4, same byte order
swapon: /dev/sda2: pagesize=4096, swapsize=1028157440, devsize=1028160000
[ 28.780000] Adding 1004056k swap on /dev/sda2. Priority:-1 extents:1 across:1004056k
.
Will now check root file system:fsck from util-linux-ng 2.17.2
[/sbin/fsck.ext3 (1) -- /] fsck.ext3 -a -C0 /dev/sda3
/dev/sda3 has been mounted 37 times without being checked, check forced.
[ 257.192000] Backtrace:=========== \ 42.8%
[ 257.192000] [<0000000040214f78>] add_partial+0x28/0x98
[ 257.192000] [<0000000040217ff8>] __slab_free+0x1d0/0x1d8
[ 257.192000] [<000000004021825c>] kmem_cache_free+0xc4/0x128
[ 257.192000] [<00000000401fd1a4>] remove_vma+0x8c/0xc0
[ 257.192000] [<00000000401fd3a8>] exit_mmap+0x1d0/0x220
[ 257.192000] [<0000000040156514>] mmput+0xd4/0x200
[ 257.192000] [<000000004015c7b8>] exit_mm+0x100/0x2c0
[ 257.192000] [<000000004015ef40>] do_exit+0x778/0x9d8
[ 257.192000] [<000000004015f1ec>] do_group_exit+0x4c/0xe0
[ 257.192000] [<000000004015f298>] sys_exit_group+0x18/0x28
[ 257.192000] [<0000000040106034>] syscall_exit+0x0/0x14
[ 257.192000]
[ 257.192000]
[ 257.192000] Kernel Fault: Code=26 regs=00000040bf1807d0 (Addr=0000000000000000)
[ 257.192000]
[ 257.192000] YZrvWESTHLNXBCVMcbcbcbcbOGFRQPDI
[ 257.192000] PSW: 00001000000001001111000000001110 Not tainted
[ 257.192000] r00-03 000000ff0804f00e 0000000040769e40 0000000040214f78 0000000000000000
[ 257.192000] r04-07 0000000040746e40 0000000000000001 0000004080ded370 0000000000000001
[ 257.192000] r08-11 0000000040654150 0000000000000000 0000000000000001 0000000000000001
[ 257.192000] r12-15 0000000000000000 00000000ffffffff 0000000000000024 0000000000000000
[ 257.192000] r16-19 00000000fb4ead9c 00000000fb4eac54 0000000000000000 0000000000000000
[ 257.192000] r20-23 000000000800000e 0000000000000001 000000007bbb7180 00000000401fd1a4
[ 257.192000] r24-27 0000000000000001 0000004080ded370 0000000000000000 0000000040746e40
[ 257.192000] r28-31 000000007ec0a908 00000040bf1807a0 00000040bf1807d0 0000000000000016
[ 257.192000] sr00-03 00000000002d9000 0000000000000000 0000000000000000 00000000002d9000
[ 257.192000] sr04-07 0000000000000000 0000000000000000 0000000000000000 0000000000000000
[ 257.192000]
[ 257.192000] IASQ: 0000000000000000 0000000000000000 IAOQ: 000000004011bbc0 000000004011bbc4
[ 257.192000] IIR: 0f4015dc ISR: 0000000000000000 IOR: 0000000000000000
[ 257.192000] CPU: 0 CR30: 00000040bf180000 CR31: fffffff0f0e098e0
[ 257.192000] ORIG_R28: 0000000040769e40
[ 257.192000] IAOQ[0]: _raw_spin_lock+0x0/0x20
[ 257.192000] IAOQ[1]: _raw_spin_lock+0x4/0x20
[ 257.192000] RP(r2): add_partial+0x28/0x98
[ 257.192000] Backtrace:
[ 257.192000] [<0000000040214f78>] add_partial+0x28/0x98
[ 257.192000] [<0000000040217ff8>] __slab_free+0x1d0/0x1d8
[ 257.192000] [<000000004021825c>] kmem_cache_free+0xc4/0x128
[ 257.192000] [<00000000401fd1a4>] remove_vma+0x8c/0xc0
[ 257.192000] [<00000000401fd3a8>] exit_mmap+0x1d0/0x220
[ 257.192000] [<0000000040156514>] mmput+0xd4/0x200
[ 257.192000] [<000000004015c7b8>] exit_mm+0x100/0x2c0
[ 257.192000] [<000000004015ef40>] do_exit+0x778/0x9d8
[ 257.192000] [<000000004015f1ec>] do_group_exit+0x4c/0xe0
[ 257.192000] [<000000004015f298>] sys_exit_group+0x18/0x28
[ 257.192000] [<0000000040106034>] syscall_exit+0x0/0x14
[ 257.192000]
[ 257.192000] Kernel panic - not syncing: Kernel Fault
[ 257.192000] Backtrace:
[ 257.192000] [<000000004011f984>] show_stack+0x14/0x20
[ 257.192000] [<000000004011f9a8>] dump_stack+0x18/0x28
[ 257.192000] [<000000004015946c>] panic+0xd4/0x368
[ 257.192000] [<0000000040120024>] parisc_terminate+0x14c/0x170
[ 257.192000] [<000000004012059c>] handle_interruption+0x2ac/0x8f8
[ 257.192000] [<000000004011bbc0>] _raw_spin_lock+0x0/0x20
[ 257.192000]
[ 257.192000] Rebooting in 5 seconds..
It seems to be a random intermittent mm crash because the next reboot
crashed with the same trace but after the fsck had completed and the
third came up to the login prompt.
James
next prev parent reply other threads:[~2011-04-19 15:46 UTC|newest]
Thread overview: 110+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-15 13:51 [PATCH] " Michal Hocko
2011-04-18 3:00 ` Hugh Dickins
2011-04-18 10:01 ` [PATCH v2] " Michal Hocko
2011-04-18 20:56 ` Andrew Morton
[not found] ` <20110419091022.GA21689@tiehlicka.suse.cz>
2011-04-19 11:09 ` [PATCH followup] mm: get rid of CONFIG_STACK_GROWSUP || CONFIG_IA64 Michal Hocko
2011-04-20 0:33 ` KOSAKI Motohiro
2011-04-20 6:59 ` Michal Hocko
2011-04-20 7:08 ` KOSAKI Motohiro
2011-04-26 7:59 ` Michal Hocko
2011-04-19 11:10 ` [PATCH v3] mm: make expand_downwards symmetrical to expand_upwards Michal Hocko
2011-04-19 15:46 ` James Bottomley [this message]
2011-04-19 16:06 ` [PATCH v3] mm: make expand_downwards symmetrical to John David Anglin
2011-04-19 16:59 ` James Bottomley
2011-04-19 16:07 ` [PATCH v3] mm: make expand_downwards symmetrical to expand_upwards James Bottomley
2011-04-19 17:05 ` Pekka Enberg
2011-04-19 17:11 ` James Bottomley
2011-04-19 17:15 ` Christoph Lameter
2011-04-19 17:48 ` James Bottomley
2011-04-19 18:10 ` Christoph Lameter
2011-04-19 18:20 ` James Bottomley
2011-04-19 18:35 ` Christoph Lameter
2011-04-19 19:49 ` James Bottomley
2011-04-19 20:56 ` Christoph Lameter
2011-04-19 21:21 ` James Bottomley
2011-04-19 21:39 ` Christoph Lameter
2011-04-19 21:48 ` James Bottomley
2011-04-19 21:58 ` Christoph Lameter
2011-04-20 1:23 ` KOSAKI Motohiro
2011-04-20 2:48 ` James Bottomley
2011-04-20 2:57 ` KOSAKI Motohiro
2011-04-20 13:50 ` Christoph Lameter
2011-04-21 13:32 ` Tejun Heo
2011-04-20 5:53 ` Pekka Enberg
2011-04-20 7:15 ` KOSAKI Motohiro
2011-04-20 7:34 ` Pekka Enberg
2011-04-20 8:40 ` KOSAKI Motohiro
2011-04-20 16:32 ` James Bottomley
2011-04-20 16:50 ` Christoph Lameter
2011-04-20 18:09 ` James Bottomley
2011-04-20 21:18 ` David Rientjes
2011-04-20 22:15 ` James Bottomley
2011-04-20 23:12 ` David Rientjes
2011-04-21 13:16 ` KOSAKI Motohiro
2011-04-21 16:37 ` James Bottomley
2011-04-21 18:33 ` Christoph Lameter
2011-04-21 18:45 ` Dave Hansen
2011-04-22 18:19 ` James Bottomley
2011-04-22 20:24 ` Dave Hansen
2011-04-22 20:35 ` James Bottomley
2011-04-22 21:33 ` James Bottomley
2011-04-23 18:34 ` [PATCH] convert parisc to sparsemem (was Re: [PATCH v3] mm: make expand_downwards symmetrical to expand_upwards) James Bottomley
2011-04-24 16:27 ` John David Anglin
2011-04-26 0:32 ` KOSAKI Motohiro
2011-04-27 16:36 ` Dave Hansen
2011-04-21 20:05 ` [PATCH v3] mm: make expand_downwards symmetrical to expand_upwards James Bottomley
2011-04-21 21:07 ` Christoph Lameter
2011-04-21 21:22 ` James Bottomley
2011-04-21 19:33 ` David Rientjes
2011-04-22 0:34 ` KOSAKI Motohiro
2011-04-21 2:27 ` [patch] parisc: set memory ranges in N_NORMAL_MEMORY when onlined David Rientjes
2011-04-21 13:03 ` [PATCH v3] mm: make expand_downwards symmetrical to expand_upwards KOSAKI Motohiro
2011-04-21 19:38 ` David Rientjes
2011-04-21 20:02 ` Christoph Lameter
2011-04-21 21:19 ` David Rientjes
2011-04-21 21:24 ` James Bottomley
2011-04-21 21:34 ` David Rientjes
2011-04-21 21:49 ` James Bottomley
2011-04-21 22:12 ` David Rientjes
2011-04-22 8:02 ` Pekka Enberg
2011-04-22 13:49 ` James Bottomley
2011-04-22 17:00 ` Pekka Enberg
2011-04-22 17:03 ` James Bottomley
2011-04-21 21:31 ` [patch] parisc: enable CONFIG_NUMA for DISCONTIGMEM and fix build errors David Rientjes
2011-04-21 21:41 ` [patch] mm: always set nodes with regular memory in N_NORMAL_MEMORY David Rientjes
2011-04-22 0:36 ` KOSAKI Motohiro
2011-04-21 22:00 ` [patch] alpha, mm: set all online nodes " David Rientjes
2011-04-21 22:01 ` [patch] m32r, " David Rientjes
2011-04-21 22:02 ` [patch] m68k, " David Rientjes
2011-04-24 1:59 ` Michael Schmitz
2011-04-24 3:14 ` KOSAKI Motohiro
2011-04-24 4:01 ` Michael Schmitz
2011-04-24 5:05 ` Michael Schmitz
2011-04-24 6:04 ` KOSAKI Motohiro
2011-04-24 11:32 ` Thorsten Glaser
2011-04-25 2:41 ` Michael Schmitz
2011-04-25 14:22 ` Thorsten Glaser
2011-04-24 12:18 ` Thorsten Glaser
2011-04-25 20:56 ` David Rientjes
2011-04-26 2:51 ` Michael Schmitz
2011-04-26 10:50 ` Thorsten Glaser
2011-04-27 13:19 ` Geert Uytterhoeven
2011-04-27 15:09 ` Thorsten Glaser
2011-04-28 3:05 ` Michael Schmitz
2011-04-20 21:05 ` [PATCH v3] mm: make expand_downwards symmetrical to expand_upwards David Rientjes
2011-04-20 11:20 ` Matthew Wilcox
2011-04-20 11:28 ` Pekka Enberg
2011-04-20 14:15 ` James Bottomley
2011-04-20 14:50 ` Christoph Lameter
2011-04-20 15:02 ` James Bottomley
2011-04-20 15:22 ` Christoph Lameter
2011-04-20 19:25 ` Matthew Wilcox
2011-04-20 21:42 ` David Rientjes
2011-04-21 16:06 ` James Bottomley
2011-04-21 22:19 ` David Rientjes
2011-04-21 22:31 ` James Bottomley
2011-04-20 13:58 ` Christoph Lameter
2011-04-20 21:34 ` David Rientjes
2011-04-20 14:07 ` Christoph Lameter
2011-04-20 2:33 ` James Bottomley
2011-04-19 17:12 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1303228009.3171.18.camel@mulgrave.site \
--to=james.bottomley@hansenpartnership.com \
--cc=akpm@linux-foundation.org \
--cc=hughd@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-parisc@vger.kernel.org \
--cc=mhocko@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®