From: Arnaldo Carvalho de Melo <acme@infradead.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: linux-kernel@vger.kernel.org, Michael Witten <mfwitten@gmail.com>,
Arnaldo Carvalho de Melo <acme@redhat.com>
Subject: [PATCH 2/6] perf tools: Makefile: Clean up `python/perf.so' rule
Date: Wed, 20 Apr 2011 13:23:52 -0300 [thread overview]
Message-ID: <1303316636-11923-3-git-send-email-acme@infradead.org> (raw)
In-Reply-To: <1303316636-11923-1-git-send-email-acme@infradead.org>
From: Michael Witten <mfwitten@gmail.com>
There is no need for a subshell or an explicit `export';
as per the POSIX Shell Command Language specification:
http://pubs.opengroup.org/onlinepubs/009695399/utilities/xcu_chap02.html#tag_02_09_01
http://pubs.opengroup.org/onlinepubs/009695399/utilities/xcu_chap02.html#tag_02_10_02
It is only necessary to include the environment variable
assignment just before the command to be run.
Also, it is better to use single-quotes, because GNU make
might expand `$(BASIC_CFLAGS)' into something that the shell
could interpret within double-quotes.
Acked-by: Raghavendra D Prabhu <rprabhu@wnohang.net>
Link: http://lkml.kernel.org/n/tip-58n38o02ocuzrm9qh096hsf5@git.kernel.org
Signed-off-by: Michael Witten <mfwitten@gmail.com>
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/Makefile | 10 ++++------
1 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/tools/perf/Makefile b/tools/perf/Makefile
index 207dee5..aaf4dd3 100644
--- a/tools/perf/Makefile
+++ b/tools/perf/Makefile
@@ -165,12 +165,10 @@ grep-libs = $(filter -l%,$(1))
strip-libs = $(filter-out -l%,$(1))
$(OUTPUT)python/perf.so: $(PYRF_OBJS)
- $(QUIET_GEN)( \
- export CFLAGS="$(BASIC_CFLAGS)"; \
- python util/setup.py --quiet build_ext --build-lib='$(OUTPUT)python' \
- --build-temp='$(OUTPUT)python/temp' \
- )
-
+ $(QUIET_GEN)CFLAGS='$(BASIC_CFLAGS)' python util/setup.py \
+ --quiet build_ext \
+ --build-lib='$(OUTPUT)python' \
+ --build-temp='$(OUTPUT)python/temp'
#
# No Perl scripts right now:
#
--
1.6.2.5
next prev parent reply other threads:[~2011-04-20 16:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-20 16:23 [GIT PULL 0/6] perf/core improvements and fixes Arnaldo Carvalho de Melo
2011-04-20 16:23 ` [PATCH 1/6] perf symbols: Give more useful names to 'self' parameters Arnaldo Carvalho de Melo
2011-04-20 16:23 ` Arnaldo Carvalho de Melo [this message]
2011-04-20 16:23 ` [PATCH 3/6] perf tools: Makefile: PYTHON{,_CONFIG} to bandage Python 3 incompatibility Arnaldo Carvalho de Melo
2011-04-20 16:23 ` [PATCH 4/6] perf tools: Move `try-cc' Arnaldo Carvalho de Melo
2011-04-20 16:23 ` [PATCH 5/6] perf tools: git mv tools/perf/{features-tests.mak,config/} Arnaldo Carvalho de Melo
2011-04-20 16:23 ` [PATCH 6/6] perf script: Add support for PERF_TYPE_RAW Arnaldo Carvalho de Melo
2011-04-21 8:58 ` [GIT PULL 0/6] perf/core improvements and fixes Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1303316636-11923-3-git-send-email-acme@infradead.org \
--to=acme@infradead.org \
--cc=acme@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mfwitten@gmail.com \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®