From: Dave Hansen <dave@linux.vnet.ibm.com>
To: Matt Fleming <matt@console-pimps.org>
Cc: Hugh Dickins <hughd@google.com>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm@vger.kernel.org, linux-kernel@vger.kernel.org,
Matt Fleming <matt.fleming@linux.intel.com>
Subject: Re: [PATCH] mm: Delete non-atomic mm counter implementation
Date: Wed, 27 Apr 2011 09:08:18 -0700 [thread overview]
Message-ID: <1303920498.9308.19700.camel@nimitz> (raw)
In-Reply-To: <1303914965-868-1-git-send-email-matt@console-pimps.org>
On Wed, 2011-04-27 at 15:36 +0100, Matt Fleming wrote:
> From: Matt Fleming <matt.fleming@linux.intel.com>
>
> The problem with having two different types of counters is that
> developers adding new code need to keep in mind whether it's safe to
> use both the atomic and non-atomic implementations. For example, when
> adding new callers of the *_mm_counter() functions a developer needs
> to ensure that those paths are always executed with page_table_lock
> held, in case we're using the non-atomic implementation of mm
> counters.
> Signed-off-by: Matt Fleming <matt.fleming@linux.intel.com>
> ---
>
> Dave, you might want to take this into your pagetable counters series
> so that you only need to worry about atomic mm counters.
Thanks for doing the patch. I'll certainly pick it up and submit it
alongside my stuff unless Andrew picks it up first.
Acked-by: Dave Hansen <dave@linux.vnet.ibm.com>
-- Dave
next prev parent reply other threads:[~2011-04-27 16:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-27 14:36 Matt Fleming
2011-04-27 15:09 ` Matt Fleming
2011-04-27 16:08 ` Dave Hansen [this message]
2011-04-28 0:08 ` KAMEZAWA Hiroyuki
2011-04-29 8:02 ` Matt Fleming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1303920498.9308.19700.camel@nimitz \
--to=dave@linux.vnet.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=hughd@google.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@vger.kernel.org \
--cc=matt.fleming@linux.intel.com \
--cc=matt@console-pimps.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®