From: David Decotigny <decot@google.com>
To: "David S. Miller" <davem@davemloft.net>,
Ben Hutchings <bhutchings@solarflare.com>,
mirq-linux@rere.qmqm.pl, Stanislaw Gruszka <sgruszka@redhat.com>,
Alexander Duyck <alexander.h.duyck@intel.com>,
Eilon Greenstein <eilong@broadcom.com>,
Grant Grundler <grundler@parisc-linux.org>,
e1000-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org
Cc: David Decotigny <decot@google.com>
Subject: [PATCHv3 5/7] acenic: Fix using the specified speed when configuring NIC
Date: Wed, 27 Apr 2011 18:27:21 -0700 [thread overview]
Message-ID: <1303954043-17440-6-git-send-email-decot@google.com> (raw)
In-Reply-To: <1303954043-17440-1-git-send-email-decot@google.com>
This tells the NIC to take the speed specified by ethtool into account
when configuring it instead of keeping the previous speed.
Signed-off-by: David Decotigny <decot@google.com>
---
drivers/net/acenic.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/acenic.c b/drivers/net/acenic.c
index a579899..82260ca 100644
--- a/drivers/net/acenic.c
+++ b/drivers/net/acenic.c
@@ -2720,7 +2720,7 @@ static int ace_set_settings(struct net_device *dev, struct ethtool_cmd *ecmd)
link |= LNK_NEGOTIATE;
if (ethtool_cmd_speed(ecmd) != speed) {
link &= ~(LNK_1000MB | LNK_100MB | LNK_10MB);
- switch (speed) {
+ switch (ethtool_cmd_speed(ecmd)) {
case SPEED_1000:
link |= LNK_1000MB;
break;
--
1.7.3.1
next prev parent reply other threads:[~2011-04-28 1:27 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-28 1:27 [PATCHv3 0/7] ethtool: generalize use of ethtool_cmd_speed API David Decotigny
2011-04-28 1:27 ` [PATCHv3 1/7] ethtool: cosmetics: enforce const-ness in ethtool_cmd_speed David Decotigny
2011-04-28 2:03 ` Ben Hutchings
2011-04-28 1:27 ` [PATCHv3 2/7] ethtool: Call ethtool's get/set_settings callbacks with cleaned data David Decotigny
2011-04-28 2:04 ` Ben Hutchings
2011-04-28 1:27 ` [PATCHv3 3/7] ethtool: Use the full 32 bit speed range in ethtool's set_settings David Decotigny
2011-04-28 2:10 ` Ben Hutchings
2011-04-28 21:14 ` David Dillow
2011-04-28 1:27 ` [PATCHv3 4/7] ethtool: cosmetic: Use ethtool ethtool_cmd_speed API David Decotigny
2011-04-28 2:12 ` Ben Hutchings
2011-04-28 1:27 ` David Decotigny [this message]
2011-04-28 1:27 ` [PATCHv3 6/7] tulip/de2104x: don't report different speeds depending on port type David Decotigny
2011-04-28 2:13 ` Ben Hutchings
2011-04-28 1:27 ` [PATCHv3 7/7] net/igb/e1000/e1000e: more robust ethtool duplex/speed configuration David Decotigny
2011-04-29 21:12 ` [PATCHv3 0/7] ethtool: generalize use of ethtool_cmd_speed API David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1303954043-17440-6-git-send-email-decot@google.com \
--to=decot@google.com \
--cc=alexander.h.duyck@intel.com \
--cc=bhutchings@solarflare.com \
--cc=davem@davemloft.net \
--cc=e1000-devel@lists.sourceforge.net \
--cc=eilong@broadcom.com \
--cc=grundler@parisc-linux.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mirq-linux@rere.qmqm.pl \
--cc=netdev@vger.kernel.org \
--cc=sgruszka@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome