From: Matthew Garrett <mjg@redhat.com>
To: x86@kernel.org
Cc: linux-kernel@vger.kernel.org, Matthew Garrett <mjg@redhat.com>
Subject: [PATCH] x86: Populate virtual address field of all EFI memmap entries
Date: Thu, 28 Apr 2011 14:02:26 -0400 [thread overview]
Message-ID: <1304013746-20239-1-git-send-email-mjg@redhat.com> (raw)
Our current implementation of SetVirtualAddressMap passes back the entire
memory map it received from the firmware, but only modifies entries that
have the runtime attribute set. Experiments (mostly involving screaming)
with real-world EFI implementations suggests that some will call
ConvertPointer on data that exist outside runtime regions anyway. The
easiest fix here seems to be to continue remapping runtime regions and
just to copy the physical address to the virtal address for other regions.
This doesn't fix any observed problems with our current implementation,
but it seems better to be safe than sorry.
Signed-off-by: Matthew Garrett <mjg@redhat.com>
---
arch/x86/platform/efi/efi.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/arch/x86/platform/efi/efi.c b/arch/x86/platform/efi/efi.c
index 0fe27d7..f11b3b0 100644
--- a/arch/x86/platform/efi/efi.c
+++ b/arch/x86/platform/efi/efi.c
@@ -507,8 +507,10 @@ void __init efi_enter_virtual_mode(void)
efi.systab = NULL;
for (p = memmap.map; p < memmap.map_end; p += memmap.desc_size) {
md = p;
- if (!(md->attribute & EFI_MEMORY_RUNTIME))
+ if (!(md->attribute & EFI_MEMORY_RUNTIME)) {
+ md->virt_addr = md->phys_addr;
continue;
+ }
size = md->num_pages << EFI_PAGE_SHIFT;
end = md->phys_addr + size;
--
1.7.4.4
reply other threads:[~2011-04-28 18:03 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1304013746-20239-1-git-send-email-mjg@redhat.com \
--to=mjg@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®