From: "Koul, Vinod" <vinod.koul@intel.com>
To: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Cc: linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org,
Dan Williams <dan.j.williams@intel.com>,
Simon Horman <horms@verge.net.au>,
Magnus Damm <damm@opensource.se>
Subject: Re: [PATCH 2/2] dmaengine: shdma: add runtime- and system-level power management
Date: Mon, 02 May 2011 15:35:47 +0530 [thread overview]
Message-ID: <1304330747.1589.23.camel@vkoul-udesk3> (raw)
In-Reply-To: <Pine.LNX.4.64.1105021117060.13244@axis700.grange>
On Mon, 2011-05-02 at 11:53 +0200, Guennadi Liakhovetski wrote:
> On Mon, 2 May 2011, Koul, Vinod wrote:
>
> > On Mon, 2011-05-02 at 11:04 +0200, Guennadi Liakhovetski wrote:
> > > On Mon, 2 May 2011, Koul, Vinod wrote:
> > >
> > > > On Fri, 2011-04-29 at 19:09 +0200, Guennadi Liakhovetski wrote:
> > > > > This patch extends and fixes runtime power management in the shdma
> > > > > driver to support powering down the DMA controller and adds support
> > > > > for system-level suspend and resume.
> > > > >
> > > > > +
> > > > > +static int sh_dmae_runtime_resume(struct device *dev)
> > > > > +{
> > > > > + struct sh_dmae_device *shdev = dev_get_drvdata(dev);
> > > > > +
> > > > > + return sh_dmae_rst(shdev);
> > > > > +}
> > > > > +
> > > > > +#ifdef CONFIG_PM
> > > > This should be removed...
> > >
> > > You mean, these functions just won't be called, but this way we save a
> > > couple of bytes if PM is not set, don't we?
> > I meant you dont need to have this, PM is usually part of core options
> > which ppl enable nowadays. Do you run with PM disabled?
>
> I actually do, but maybe that's not a very important argument. So, if the
> only difference is a couple of kilobytes in the kernel size, then maybe we
> can just keep it always enabled. There are no other side-efects to it,
> right?
Yes, other driver currently do this...
--
~Vinod
next prev parent reply other threads:[~2011-05-02 10:37 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-29 17:09 [PATCH 0/2] locking power management for shdma dmaengine driver Guennadi Liakhovetski
2011-04-29 17:09 ` [PATCH 1/2] dmaengine: shdma: fix locking Guennadi Liakhovetski
2011-05-31 6:50 ` Paul Mundt
2011-05-31 9:26 ` Guennadi Liakhovetski
2011-04-29 17:09 ` [PATCH 2/2] dmaengine: shdma: add runtime- and system-level power management Guennadi Liakhovetski
2011-05-02 8:03 ` Koul, Vinod
2011-05-02 9:04 ` Guennadi Liakhovetski
2011-05-02 8:38 ` Koul, Vinod
2011-05-02 9:53 ` Guennadi Liakhovetski
2011-05-02 10:05 ` Koul, Vinod [this message]
2011-05-02 7:20 ` [PATCH 0/2] locking power management for shdma dmaengine driver Simon Horman
2011-05-02 7:59 ` Guennadi Liakhovetski
2011-05-02 10:51 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1304330747.1589.23.camel@vkoul-udesk3 \
--to=vinod.koul@intel.com \
--cc=damm@opensource.se \
--cc=dan.j.williams@intel.com \
--cc=g.liakhovetski@gmx.de \
--cc=horms@verge.net.au \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®