From: Steven Rostedt <rostedt@goodmis.org>
To: Michael Rubin <mrubin@google.com>
Cc: Vaibhav Nagarnaik <vnagarnaik@google.com>,
Don Zickus <dzickus@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, David Sharp <dhsharp@google.com>,
linux-kernel@vger.kernel.org, x86@kernel.org,
Aditya Kali <adityakali@google.com>
Subject: Re: [PATCH 1/2] x86: Change trap definitions to enumerated values
Date: Tue, 03 May 2011 18:54:36 -0400 [thread overview]
Message-ID: <1304463276.25414.2420.camel@gandalf.stny.rr.com> (raw)
In-Reply-To: <BANLkTik4N_cWuw2Vq65UX5jCW+AccQHAHw@mail.gmail.com>
On Tue, 2011-05-03 at 15:41 -0700, Michael Rubin wrote:
> On Tue, May 3, 2011 at 12:00 PM, Vaibhav Nagarnaik
> <vnagarnaik@google.com> wrote:
> > Would it make better sense to separate this patch into 2 patches, the first
> > one replacing the numbers to enums and the second one adding the tracepoints?
>
> Yes please do that.
> Each patch should stand on its own with one simple purpose if possible.
Agreed. Don't break up patches just because of size, but instead with
purpose. Usually this breaks up large patches as you want to build up
something, piece by piece, where each piece has a specific, easy to
understand goal.
This is actually what is taking me so long to get my ftrace rewrite out.
Not the actual work, but coming up with a way to break up that work in
logical steps, that makes it easy to understand and review.
-- Steve
next prev parent reply other threads:[~2011-05-03 22:54 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-22 23:03 [PATCH 1/2] trace: Add trap entry/exit tracepoints Vaibhav Nagarnaik
2011-04-22 23:03 ` [PATCH 2/2] x86: Change trap definitions to enumerated values Vaibhav Nagarnaik
2011-04-28 23:15 ` Vaibhav Nagarnaik
2011-04-28 23:40 ` Steven Rostedt
2011-04-29 0:38 ` Thomas Gleixner
2011-04-25 23:39 ` [PATCH 1/2] trace: Add trap entry/exit tracepoints Vaibhav Nagarnaik
2011-04-28 23:36 ` Steven Rostedt
2011-04-29 0:33 ` Thomas Gleixner
2011-04-30 0:52 ` Vaibhav Nagarnaik
2011-04-30 0:52 ` [PATCH 1/2] x86: Change trap definitions to enumerated values Vaibhav Nagarnaik
2011-05-03 13:18 ` Don Zickus
2011-05-03 19:00 ` Vaibhav Nagarnaik
2011-05-03 22:41 ` Michael Rubin
2011-05-03 22:54 ` Steven Rostedt [this message]
2011-05-03 23:08 ` David Sharp
2011-04-30 0:52 ` [PATCH 2/2] trace: Add trap entry/exit tracepoints Vaibhav Nagarnaik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1304463276.25414.2420.camel@gandalf.stny.rr.com \
--to=rostedt@goodmis.org \
--cc=adityakali@google.com \
--cc=dhsharp@google.com \
--cc=dzickus@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=mrubin@google.com \
--cc=tglx@linutronix.de \
--cc=vnagarnaik@google.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®