From: John Stultz <john.stultz@linaro.org>
To: lkml <linux-kernel@vger.kernel.org>
Cc: John Stultz <john.stultz@linaro.org>,
Alessandro Zummo <a.zummo@towertech.it>,
Thomas Gleixner <tglx@linutronix.de>,
rtc-linux@googlegroups.com
Subject: [PATCH 00/11] rtc: Fix rtc breakage found by commit f44f7f96a20
Date: Fri, 6 May 2011 18:20:43 -0700 [thread overview]
Message-ID: <1304731254-3238-1-git-send-email-john.stultz@linaro.org> (raw)
Since commit f44f7f96a20 ("RTC: Initialize kernel state from RTC")
landed in 2.6.39-rc1, we've seen a few reports of boot time hangs
cropping up. It ends up that the problematic rtc drivers were
calling rtc_device_register before it finished initializing critical
data for the rtc driver to function.
Wolfram Sang noticed that this issue was actually more common then
just the few reports seen, and motivated me to do a complete audit
of all the RTC drivers to ensure they were not being registered
before any critical drvdata was initialized.
This patchset is the result of that audit, along with earlier
noted fixes from Wolfram's and Uwe.
Thanks again to Wolfram and Uwe for the patches and helping make
these issues a priority.
CC: Alessandro Zummo <a.zummo@towertech.it>
CC: Thomas Gleixner <tglx@linutronix.de>
CC: rtc-linux@googlegroups.com
John Stultz (7):
rtc: ds1286: Initialize drvdata before registering device
rtc: m41t80: Initialize clientdata before registering device
rtc: max8925: Initialize drvdata before registering device
rtc: max8998: Initialize drvdata before registering device
rtc: msm6242: Initialize drvdata before registering device
rtc: pcap: Initialize drvdata before registering device
rtc: rp5c01: Initialize drvdata before registering device
Uwe Kleine-König (1):
rtc: mc13xxx: Don't call rtc_device_register while holding lock
Wolfram Sang (3):
rtc: mxc: Initialize drvdata before registering device
rtc: davinci: Initialize drvdata before registering device
rtc: ep93xx: Initialize drvdata before registering device
drivers/rtc/rtc-davinci.c | 5 +++--
drivers/rtc/rtc-ds1286.c | 2 +-
drivers/rtc/rtc-ep93xx.c | 5 ++---
drivers/rtc/rtc-m41t80.c | 5 +++--
drivers/rtc/rtc-max8925.c | 5 +++--
drivers/rtc/rtc-max8998.c | 5 +++--
drivers/rtc/rtc-mc13xxx.c | 8 ++++++--
drivers/rtc/rtc-msm6242.c | 3 ++-
drivers/rtc/rtc-mxc.c | 19 +++++++++++--------
drivers/rtc/rtc-pcap.c | 4 +++-
drivers/rtc/rtc-rp5c01.c | 5 +++--
11 files changed, 40 insertions(+), 26 deletions(-)
--
1.7.3.2.146.gca209
next reply other threads:[~2011-05-07 1:21 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-07 1:20 John Stultz [this message]
2011-05-07 1:20 ` [PATCH 01/11] rtc: mxc: Initialize drvdata before registering device John Stultz
2011-05-07 1:20 ` [PATCH 02/11] rtc: davinci: " John Stultz
2011-05-07 1:20 ` [PATCH 03/11] rtc: ep93xx: " John Stultz
2011-05-07 1:20 ` [PATCH 04/11] rtc: ds1286: " John Stultz
2011-05-07 1:20 ` [PATCH 05/11] rtc: m41t80: Initialize clientdata " John Stultz
2011-05-07 1:20 ` [PATCH 06/11] rtc: max8925: Initialize drvdata " John Stultz
2011-05-07 1:20 ` [PATCH 07/11] rtc: max8998: " John Stultz
2011-05-07 1:20 ` [PATCH 08/11] rtc: msm6242: " John Stultz
2011-05-07 1:20 ` [PATCH 09/11] rtc: pcap: " John Stultz
2011-05-07 1:20 ` [PATCH 10/11] rtc: rp5c01: " John Stultz
2011-05-07 1:20 ` [PATCH 11/11] rtc: mc13xxx: Don't call rtc_device_register while holding lock John Stultz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1304731254-3238-1-git-send-email-john.stultz@linaro.org \
--to=john.stultz@linaro.org \
--cc=a.zummo@towertech.it \
--cc=linux-kernel@vger.kernel.org \
--cc=rtc-linux@googlegroups.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome