From: "Woodhouse, David" <david.woodhouse@intel.com>
To: "Song, Youquan" <youquan.song@intel.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"mingo@elte.hu" <mingo@elte.hu>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"hpa@zytor.com" <hpa@zytor.com>,
"hpa@linux.intel.com" <hpa@linux.intel.com>,
"Kay, Allen M" <allen.m.kay@intel.com>,
"Siddha, Suresh B" <suresh.b.siddha@intel.com>,
"Liu, Kent" <kent.liu@intel.com>,
Youquan Song <youquan.song@linux.intel.com>
Subject: Re: [PATCH v2] x86, vt-d: enable x2apic opt out
Date: Wed, 11 May 2011 18:21:13 +0100 [thread overview]
Message-ID: <1305134473.30435.178.camel@i7.infradead.org> (raw)
In-Reply-To: <1302764783-24491-1-git-send-email-youquan.song@intel.com>
[-- Attachment #1: Type: text/plain, Size: 809 bytes --]
On Thu, 2011-04-14 at 08:06 +0100, Song, Youquan wrote:
> + pr_info("Not enabling x2apic, firmware requests OS opt-out "
> + "x2apic.\n");
This output is far too innocuous. At the very least, it should have a
clear statement that this should leave you vulnerable to IRQ injection
attacks that intr-remapping + x2apic would have protected against.
It should probably look more like:
WARN (1, "Your BIOS is broken and requested that x2apic be disabled\n"
"This will leave your machine vulnerable to irq-injection attacks\n"
"Use 'intel_iommu=no_x2apic_optout' to override BIOS request\n");
--
David Woodhouse Open Source Technology Centre
David.Woodhouse@intel.com Intel Corporation
[-- Attachment #2: smime.p7s --]
[-- Type: application/x-pkcs7-signature, Size: 6242 bytes --]
next prev parent reply other threads:[~2011-05-11 17:21 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-14 7:06 Youquan Song
2011-05-11 15:07 ` Woodhouse, David
2011-05-12 3:39 ` Youquan Song
2011-05-11 15:39 ` David Woodhouse
2011-05-11 22:38 ` Valdis.Kletnieks
2011-05-16 20:32 ` Alex Williamson
2011-05-17 9:49 ` Woodhouse, David
2011-05-17 12:50 ` Alex Williamson
2011-05-18 22:58 ` Woodhouse, David
2011-05-19 5:43 ` Alex Williamson
2011-05-11 17:21 ` Woodhouse, David [this message]
2011-05-12 1:52 ` Youquan Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1305134473.30435.178.camel@i7.infradead.org \
--to=david.woodhouse@intel.com \
--cc=akpm@linux-foundation.org \
--cc=allen.m.kay@intel.com \
--cc=hpa@linux.intel.com \
--cc=hpa@zytor.com \
--cc=kent.liu@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=suresh.b.siddha@intel.com \
--cc=tglx@linutronix.de \
--cc=youquan.song@intel.com \
--cc=youquan.song@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®