From: Borislav Petkov <bp@amd64.org>
To: "Nick Bowler" <nbowler@elliptictech.com>,
"Jörg-Volker Peetz" <jvpeetz@web.de>
Cc: Boris Ostrovsky <boris.ostrovsky@amd.com>,
Andreas Herrmann <andreas.herrmann3@amd.com>,
Greg Kroah-Hartman <greg@kroah.com>,
Hans Rosenfeld <hans.rosenfeld@amd.com>, X86-ML <x86@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Borislav Petkov <borislav.petkov@amd.com>
Subject: [PATCH 1/2] Revert "x86, AMD: Fix APIC timer erratum 400 affecting K8 Rev.A-E processors"
Date: Tue, 17 May 2011 14:55:18 +0200 [thread overview]
Message-ID: <1305636919-31165-2-git-send-email-bp@amd64.org> (raw)
In-Reply-To: <1305636919-31165-1-git-send-email-bp@amd64.org>
From: Borislav Petkov <borislav.petkov@amd.com>
This reverts commit e20a2d205c05cef6b5783df339a7d54adeb50962.
Moving the lower endpoint of the Erratum 400 check to accomodate earlier
K8 revisions (A-E) opens a can of worms which is simply not worth to fix
properly by tweaking the errata checking framework:
* missing IntPenging MSR on revisions < CG cause #GP:
http://marc.info/?l=linux-kernel&m=130541471818831
* makes earlier revisions use the LAPIC timer instead of the C1E idle
routine which switches to HPET, thus not waking up in deeper C-states:
http://lkml.org/lkml/2011/4/24/20
Therefore, leave the original boundary starting with K8-revF.
---
arch/x86/kernel/cpu/amd.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/x86/kernel/cpu/amd.c b/arch/x86/kernel/cpu/amd.c
index bb9eb29..3532d3b 100644
--- a/arch/x86/kernel/cpu/amd.c
+++ b/arch/x86/kernel/cpu/amd.c
@@ -698,7 +698,7 @@ cpu_dev_register(amd_cpu_dev);
*/
const int amd_erratum_400[] =
- AMD_OSVW_ERRATUM(1, AMD_MODEL_RANGE(0x0f, 0x4, 0x2, 0xff, 0xf),
+ AMD_OSVW_ERRATUM(1, AMD_MODEL_RANGE(0xf, 0x41, 0x2, 0xff, 0xf),
AMD_MODEL_RANGE(0x10, 0x2, 0x1, 0xff, 0xf));
EXPORT_SYMBOL_GPL(amd_erratum_400);
--
1.7.4.rc2
next prev parent reply other threads:[~2011-05-17 12:56 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-17 12:55 [PATCH 0/2] AMD ARAT fixes Borislav Petkov
2011-05-17 12:55 ` Borislav Petkov [this message]
2011-05-17 12:55 ` [PATCH 2/2] x86, AMD: Fix ARAT feature setting again Borislav Petkov
2011-05-17 13:47 ` [tip:x86/urgent] " tip-bot for Borislav Petkov
2011-05-17 16:38 ` [PATCH 0/2] AMD ARAT fixes Jörg-Volker Peetz
2011-05-17 16:53 ` Borislav Petkov
2011-05-17 17:21 ` Jörg-Volker Peetz
2011-05-17 17:46 ` Borislav Petkov
2011-05-17 17:51 ` Jörg-Volker Peetz
2011-05-17 18:01 ` Borislav Petkov
2011-05-17 22:30 ` Nick Bowler
2011-05-18 6:51 ` Borislav Petkov
2011-05-18 15:50 ` Borislav Petkov
2011-05-20 14:37 ` Chuck Ebbert
2011-05-20 18:10 ` Boris Ostrovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1305636919-31165-2-git-send-email-bp@amd64.org \
--to=bp@amd64.org \
--cc=andreas.herrmann3@amd.com \
--cc=boris.ostrovsky@amd.com \
--cc=borislav.petkov@amd.com \
--cc=greg@kroah.com \
--cc=hans.rosenfeld@amd.com \
--cc=jvpeetz@web.de \
--cc=linux-kernel@vger.kernel.org \
--cc=nbowler@elliptictech.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®