mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: Stephane Eranian <eranian@google.com>
Cc: linux-kernel@vger.kernel.org, acme@redhat.com, mingo@elte.hu
Subject: Re: [PATCH] perf: make annotate more readable
Date: Tue, 17 May 2011 17:46:03 +0200	[thread overview]
Message-ID: <1305647163.2466.5917.camel@twins> (raw)
In-Reply-To: <20110517153207.GA9834@quad>

On Tue, 2011-05-17 at 17:32 +0200, Stephane Eranian wrote:
> This patch adds two new options to perf annotate:
> 	- -R, --no-asm-raw : do not display raw instruction encodings
> 	- -S, --no-source  : do not interleave source code with assembly code
> 
> We believe those options make the output of annotate more readable.
> Systematically displaying source can make it hard to follow code and
> especially optimized code.

Agreed, asm->C maps from optimized code are a mess.

> Raw encodings are not useful in most cases.

Also true.

Acked-by: Peter Zijlstra <a.p.zijlstra@chello.nl>

  reply	other threads:[~2011-05-17 15:46 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-17 15:32 Stephane Eranian
2011-05-17 15:46 ` Peter Zijlstra [this message]
2011-06-03 18:56 ` Arnaldo Carvalho de Melo
2011-06-03 18:59   ` Arnaldo Carvalho de Melo
2011-06-03 19:04 ` Måns Rullgård
2011-08-18 20:13 ` [tip:perf/core] perf annotate: Make output " tip-bot for Stephane Eranian

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1305647163.2466.5917.camel@twins \
    --to=peterz@infradead.org \
    --cc=acme@redhat.com \
    --cc=eranian@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®