From: Steven Rostedt <rostedt@goodmis.org>
To: Rakib Mullick <rakib.mullick@gmail.com>
Cc: hpa@zytor.com, Thomas Gleixner <tglx@linutronix.de>,
linux-kernel@vger.kernel.org, x86@kernel.org,
Frederic Weisbecker <fweisbec@gmail.com>
Subject: Re: [PATCH] x86, ftrace: Fix compiler warning in ftrace.c
Date: Wed, 18 May 2011 09:30:19 -0400 [thread overview]
Message-ID: <1305725419.26849.16.camel@gandalf.stny.rr.com> (raw)
In-Reply-To: <BANLkTinUCh_ZbfxEtC4XYOqN_q6_yBq92Q@mail.gmail.com>
On Wed, 2011-05-18 at 11:02 +0600, Rakib Mullick wrote:
>
>
> Cause, __probe_kernel_write() currently takes void * as its parameter.
> That means all the users of __probe_kernel_write() currently passes
> void *. If we change __probe_kernel_write's parameter ( src) from void
> * to const void * , then all the callers also needs to do that. Isn't
> it?
No.
Look at __probe_kernel_write() itself. It calls
__copy_to_user_in_atomic() which takes const void *src, where we pass in
void *src. That __probe_kernel_write() having void *src is actually a
bug.
Make that a separate patch, or maybe I'll just do it.
-- Steve
prev parent reply other threads:[~2011-05-18 13:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-12 17:33 Rakib Mullick
2011-05-17 16:04 ` Steven Rostedt
[not found] ` <BANLkTim2rcr9F=5+C9t-BU8OVfbWw5mFyQ@mail.gmail.com>
2011-05-17 17:45 ` Steven Rostedt
[not found] ` <BANLkTinUCh_ZbfxEtC4XYOqN_q6_yBq92Q@mail.gmail.com>
2011-05-18 13:30 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1305725419.26849.16.camel@gandalf.stny.rr.com \
--to=rostedt@goodmis.org \
--cc=fweisbec@gmail.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rakib.mullick@gmail.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®