From: Steven Rostedt <rostedt@goodmis.org>
To: Hillf Danton <dhillf@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Mike Galbraith <efault@gmx.de>, Ingo Molnar <mingo@elte.hu>,
Peter Zijlstra <peterz@infradead.org>,
Yong Zhang <yong.zhang0@gmail.com>
Subject: Re: [PATCH] sched: change pull_rt_task() to decrease time waiting on runqueue
Date: Wed, 18 May 2011 11:20:37 -0400 [thread overview]
Message-ID: <1305732037.11267.7.camel@gandalf.stny.rr.com> (raw)
In-Reply-To: <BANLkTingJ7s5SR+QWuE=_P5tcbuaB_bEwQ@mail.gmail.com>
On Wed, 2011-05-18 at 22:54 +0800, Hillf Danton wrote:
> In short, if there are pushable tasks and if there are RQs,
> NOT LIMITED TO our RQ, in lower priority, tasks should be pushed to
> RQs as many as we could.
I understand what you are trying to do. But this change modifies a lot
of assumptions. Please supply test cases that shows how this helps.
Have a look at:
http://lwn.net/Articles/425583/
Where I did a bit of work just to make sure my change to sched_rt.c was
appropriate. Just coming up with scenarios may not be good enough.
Seeing it in practice is worth much more.
For example, you may be making the fast path slower. This may do what
you expect, with a hit in performance. I'm not sure I like that idea.
-- Steve
next prev parent reply other threads:[~2011-05-18 15:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-18 12:57 Hillf Danton
2011-05-18 13:27 ` Steven Rostedt
2011-05-18 14:54 ` Hillf Danton
2011-05-18 15:20 ` Steven Rostedt [this message]
2011-05-19 13:55 ` Hillf Danton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1305732037.11267.7.camel@gandalf.stny.rr.com \
--to=rostedt@goodmis.org \
--cc=dhillf@gmail.com \
--cc=efault@gmx.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=yong.zhang0@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®