From: Steven Rostedt <rostedt@goodmis.org>
To: Frederic Weisbecker <fweisbec@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>, Ingo Molnar <mingo@elte.hu>
Subject: Re: [PATCH] tracing: Register static events output early
Date: Wed, 18 May 2011 19:37:19 -0400 [thread overview]
Message-ID: <1305761839.11267.23.camel@gandalf.stny.rr.com> (raw)
In-Reply-To: <1305761368-5488-1-git-send-email-fweisbec@gmail.com>
On Thu, 2011-05-19 at 01:29 +0200, Frederic Weisbecker wrote:
> diff --git a/kernel/trace/trace_output.c b/kernel/trace/trace_output.c
> index cf535cc..ad92d9c 100644
> --- a/kernel/trace/trace_output.c
> +++ b/kernel/trace/trace_output.c
> @@ -1278,4 +1278,4 @@ __init static int init_events(void)
>
> return 0;
> }
> -device_initcall(init_events);
> +early_initcall(init_events);
Hmm, careful here. The ring buffers are also allocated at early_init().
But you may be OK, as things like trace_printk() don't do anything if
"tracing_disabled" is set, and it's set on bootup and cleared after we
allocate the buffers.
-- Steve
next prev parent reply other threads:[~2011-05-18 23:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-18 23:29 Frederic Weisbecker
2011-05-18 23:37 ` Steven Rostedt [this message]
2011-05-18 23:40 ` Frederic Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1305761839.11267.23.camel@gandalf.stny.rr.com \
--to=rostedt@goodmis.org \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®