mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jim Cromie <jim.cromie@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: gregkh@suse.de, Jim Cromie <jim.cromie@gmail.com>,
	Doug Gilbert <dgilbert@interlog.com>,
	linux-scsi@vger.kernel.org, Benny Halevy <bhalevy@panasas.com>,
	Boaz Harrosh <bharrosh@panasas.com>,
	osd-dev@open-osd.org,
	Anil Ravindranath <anil_ravindranath@pmc-sierra.com>
Subject: [PATCH 08/23] use register_chrdev_ids in drivers/scsi/
Date: Thu, 19 May 2011 15:33:11 -0600	[thread overview]
Message-ID: <1305840792-25877-9-git-send-email-jim.cromie@gmail.com> (raw)
In-Reply-To: <1305840792-25877-1-git-send-email-jim.cromie@gmail.com>

cc: Doug Gilbert <dgilbert@interlog.com>
cc: linux-scsi@vger.kernel.org
cc: Benny Halevy <bhalevy@panasas.com>
cc: Boaz Harrosh <bharrosh@panasas.com>
cc: osd-dev@open-osd.org
cc: Anil Ravindranath <anil_ravindranath@pmc-sierra.com>
cc: linux-scsi@vger.kernel.org
Signed-off-by: Jim Cromie <jim.cromie@gmail.com>
---
 drivers/scsi/osd/osd_uld.c |    6 +++---
 drivers/scsi/pmcraid.c     |    3 +--
 drivers/scsi/sg.c          |    6 +++---
 drivers/scsi/st.c          |    7 +++----
 4 files changed, 10 insertions(+), 12 deletions(-)

diff --git a/drivers/scsi/osd/osd_uld.c b/drivers/scsi/osd/osd_uld.c
index b31a8e3..18dcd38 100644
--- a/drivers/scsi/osd/osd_uld.c
+++ b/drivers/scsi/osd/osd_uld.c
@@ -528,6 +528,7 @@ static struct scsi_driver osd_driver = {
 static int __init osd_uld_init(void)
 {
 	int err;
+	dev_t devt = MKDEV(SCSI_OSD_MAJOR, 0);
 
 	err = class_register(&osd_uld_class);
 	if (err) {
@@ -535,8 +536,7 @@ static int __init osd_uld_init(void)
 		return err;
 	}
 
-	err = register_chrdev_region(MKDEV(SCSI_OSD_MAJOR, 0),
-				     SCSI_OSD_MAX_MINOR, osd_name);
+	err = register_chrdev_ids(&devt, SCSI_OSD_MAX_MINOR, osd_name);
 	if (err) {
 		OSD_ERR("Unable to register major %d for osd ULD => %d\n",
 			SCSI_OSD_MAJOR, err);
@@ -553,7 +553,7 @@ static int __init osd_uld_init(void)
 	return 0;
 
 err_out_chrdev:
-	unregister_chrdev_region(MKDEV(SCSI_OSD_MAJOR, 0), SCSI_OSD_MAX_MINOR);
+	unregister_chrdev_region(devt, SCSI_OSD_MAX_MINOR);
 err_out:
 	class_unregister(&osd_uld_class);
 	return err;
diff --git a/drivers/scsi/pmcraid.c b/drivers/scsi/pmcraid.c
index 7f636b1..61a2207 100644
--- a/drivers/scsi/pmcraid.c
+++ b/drivers/scsi/pmcraid.c
@@ -6100,8 +6100,7 @@ static int __init pmcraid_init(void)
 			 PMCRAID_DRIVER_NAME,
 			 PMCRAID_DRIVER_VERSION, PMCRAID_DRIVER_DATE);
 
-	error = alloc_chrdev_region(&dev, 0,
-				    PMCRAID_MAX_ADAPTERS,
+	error = register_chrdev_ids(&dev, PMCRAID_MAX_ADAPTERS,
 				    PMCRAID_DEVFILE);
 
 	if (error) {
diff --git a/drivers/scsi/sg.c b/drivers/scsi/sg.c
index 909ed9e..e741988 100644
--- a/drivers/scsi/sg.c
+++ b/drivers/scsi/sg.c
@@ -1575,6 +1575,7 @@ static int __init
 init_sg(void)
 {
 	int rc;
+	dev_t devt = MKDEV(SCSI_GENERIC_MAJOR, 0);
 
 	if (scatter_elem_sz < PAGE_SIZE) {
 		scatter_elem_sz = PAGE_SIZE;
@@ -1585,8 +1586,7 @@ init_sg(void)
 	else
 		def_reserved_size = sg_big_buff;
 
-	rc = register_chrdev_region(MKDEV(SCSI_GENERIC_MAJOR, 0), 
-				    SG_MAX_DEVS, "sg");
+	rc = register_chrdev_ids(&devt, SG_MAX_DEVS, "sg");
 	if (rc)
 		return rc;
         sg_sysfs_class = class_create(THIS_MODULE, "scsi_generic");
@@ -1604,7 +1604,7 @@ init_sg(void)
 	}
 	class_destroy(sg_sysfs_class);
 err_out:
-	unregister_chrdev_region(MKDEV(SCSI_GENERIC_MAJOR, 0), SG_MAX_DEVS);
+	unregister_chrdev_region(devt, SG_MAX_DEVS);
 	return rc;
 }
 
diff --git a/drivers/scsi/st.c b/drivers/scsi/st.c
index 1871b8a..5cce227 100644
--- a/drivers/scsi/st.c
+++ b/drivers/scsi/st.c
@@ -4260,6 +4260,7 @@ static void scsi_tape_release(struct kref *kref)
 static int __init init_st(void)
 {
 	int err;
+	dev_t devt = MKDEV(SCSI_TAPE_MAJOR, 0);
 
 	validate_options();
 
@@ -4272,8 +4273,7 @@ static int __init init_st(void)
 		return PTR_ERR(st_sysfs_class);
 	}
 
-	err = register_chrdev_region(MKDEV(SCSI_TAPE_MAJOR, 0),
-				     ST_MAX_TAPE_ENTRIES, "st");
+	err = register_chrdev_ids(&devt, ST_MAX_TAPE_ENTRIES, "st");
 	if (err) {
 		printk(KERN_ERR "Unable to get major %d for SCSI tapes\n",
 		       SCSI_TAPE_MAJOR);
@@ -4293,8 +4293,7 @@ static int __init init_st(void)
 err_scsidrv:
 	scsi_unregister_driver(&st_template.gendrv);
 err_chrdev:
-	unregister_chrdev_region(MKDEV(SCSI_TAPE_MAJOR, 0),
-				 ST_MAX_TAPE_ENTRIES);
+	unregister_chrdev_region(devt, ST_MAX_TAPE_ENTRIES);
 err_class:
 	class_destroy(st_sysfs_class);
 	return err;
-- 
1.7.4.4


  parent reply	other threads:[~2011-05-19 21:34 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-19 21:33 [PATCH 00/23] add register_chrdev_ids() to char_dev.c, API Jim Cromie
2011-05-19 21:33 ` [PATCH 02/23] reimplement alloc_chrdev_region with register_chrdev_ids Jim Cromie
2011-05-19 21:33 ` [PATCH 03/23] use register_chrdev_ids to replace (register|alloc)_chrdev_region Jim Cromie
2011-05-19 21:33 ` [PATCH 04/23] use register_chrdev_ids in drivers/tty/ Jim Cromie
2011-05-19 21:33 ` [PATCH 05/23] use register_chrdev_ids in drivers/infiniband/ Jim Cromie
2011-05-19 21:33 ` [PATCH 06/23] use register_chrdev_ids in drivers/media/ Jim Cromie
2011-05-21 12:48   ` Mauro Carvalho Chehab
2011-05-19 21:33 ` [PATCH 07/23] use register_chrdev_ids in drivers/s390/ Jim Cromie
2011-05-19 21:33 ` Jim Cromie [this message]
2011-05-20 15:42   ` [PATCH 08/23] use register_chrdev_ids in drivers/scsi/ Boaz Harrosh
2011-05-21  4:21     ` Jim Cromie
2011-05-21  7:59       ` Boaz Harrosh
2011-05-19 21:33 ` [PATCH 09/23] use register_chrdev_ids in drivers/staging/ Jim Cromie
2011-05-19 22:44 ` [PATCH 00/23] add register_chrdev_ids() to char_dev.c, API Greg KH
2011-05-21  5:15   ` Jim Cromie
2011-05-21 21:14     ` Greg KH
2011-05-22 14:55       ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1305840792-25877-9-git-send-email-jim.cromie@gmail.com \
    --to=jim.cromie@gmail.com \
    --cc=anil_ravindranath@pmc-sierra.com \
    --cc=bhalevy@panasas.com \
    --cc=bharrosh@panasas.com \
    --cc=dgilbert@interlog.com \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=osd-dev@open-osd.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome