mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Gustavo F. Padovan" <padovan@profusion.mobi>
To: linux-kernel@vger.kernel.org
Cc: Thomas Gleixner <tglx@linutronix.de> (maintainer:X86
	ARCHITECTURE...),
	Ingo Molnar <mingo@redhat.com> (maintainer:X86 ARCHITECTURE... 
	,commit_signer:1/3=33%),
	"H. Peter Anvin" <hpa@zytor.com> (maintainer:X86 ARCHITECTURE...),
	x86@kernel.org (maintainer:X86 ARCHITECTURE...),
	Pekka Paalanen <pq@iki.fi> (commit_signer:2/3=67%),
	"Gustavo F. Padovan" <padovan@profusion.mobi>
	(commit_signer:1/3=33%),
	Frederic Weisbecker <fweisbec@gmail.com> (commit_signer:1/3=33%),
	Marcin Slusarz <marcin.slusarz@gmail.com> (commit_signer:1/3=33%)
Subject: [PATCH 6/8] x86: Kill set but not used warnings in pf_in.c
Date: Fri, 20 May 2011 16:13:03 -0300	[thread overview]
Message-ID: <1305918786-7239-6-git-send-email-padovan@profusion.mobi> (raw)
In-Reply-To: <1305918786-7239-5-git-send-email-padovan@profusion.mobi>

Signed-off-by: Gustavo F. Padovan <padovan@profusion.mobi>
---
 arch/x86/mm/pf_in.c |   14 +++-----------
 1 files changed, 3 insertions(+), 11 deletions(-)

diff --git a/arch/x86/mm/pf_in.c b/arch/x86/mm/pf_in.c
index 38e6d17..9f0614d 100644
--- a/arch/x86/mm/pf_in.c
+++ b/arch/x86/mm/pf_in.c
@@ -414,22 +414,17 @@ unsigned long get_ins_reg_val(unsigned long ins_addr, struct pt_regs *regs)
 	unsigned char *p;
 	struct prefix_bits prf;
 	int i;
-	unsigned long rv;
 
 	p = (unsigned char *)ins_addr;
 	p += skip_prefix(p, &prf);
 	p += get_opcode(p, &opcode);
 	for (i = 0; i < ARRAY_SIZE(reg_rop); i++)
-		if (reg_rop[i] == opcode) {
-			rv = REG_READ;
+		if (reg_rop[i] == opcode)
 			goto do_work;
-		}
 
 	for (i = 0; i < ARRAY_SIZE(reg_wop); i++)
-		if (reg_wop[i] == opcode) {
-			rv = REG_WRITE;
+		if (reg_wop[i] == opcode)
 			goto do_work;
-		}
 
 	printk(KERN_ERR "mmiotrace: Not a register instruction, opcode "
 							"0x%02x\n", opcode);
@@ -474,16 +469,13 @@ unsigned long get_ins_imm_val(unsigned long ins_addr)
 	unsigned char *p;
 	struct prefix_bits prf;
 	int i;
-	unsigned long rv;
 
 	p = (unsigned char *)ins_addr;
 	p += skip_prefix(p, &prf);
 	p += get_opcode(p, &opcode);
 	for (i = 0; i < ARRAY_SIZE(imm_wop); i++)
-		if (imm_wop[i] == opcode) {
-			rv = IMM_WRITE;
+		if (imm_wop[i] == opcode)
 			goto do_work;
-		}
 
 	printk(KERN_ERR "mmiotrace: Not an immediate instruction, opcode "
 							"0x%02x\n", opcode);
-- 
1.7.5.1


  reply	other threads:[~2011-05-20 19:14 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-20 19:12 [PATCH 1/8] mm: Kill set but not used var in bdi_debug_stats_show() Gustavo F. Padovan
2011-05-20 19:12 ` [PATCH 2/8] x86: Fix set but not used in ghash_async_setkey() Gustavo F. Padovan
2011-05-20 19:13   ` [PATCH 3/8] x86: Kill set but not used warning Gustavo F. Padovan
2011-05-20 19:13     ` [PATCH 4/8] x86: Kill set but not used warnings in tlb_uv.c Gustavo F. Padovan
2011-05-20 19:13       ` [PATCH 5/8] x86: Kill set but not used warning in test_NX() Gustavo F. Padovan
2011-05-20 19:13         ` Gustavo F. Padovan [this message]
2011-05-20 19:13           ` [PATCH 7/8] 9p: Kill set but not used warnings Gustavo F. Padovan
2011-05-20 19:13             ` [PATCH 8/8] apparmor: Kill set but no used warning in common_mmap() Gustavo F. Padovan
2011-05-21 17:21     ` [tip:x86/urgent] x86: Eliminate various 'set but not used' warnings tip-bot for Gustavo F. Padovan
2011-05-23 10:17     ` [PATCH 3/8] x86: Kill set but not used warning Roedel, Joerg
2011-05-23 10:18       ` Ingo Molnar
2011-05-26  3:29   ` [PATCH 2/8] x86: Fix set but not used in ghash_async_setkey() Herbert Xu
2011-05-20 19:23 ` [PATCH 1/8] mm: Kill set but not used var in bdi_debug_stats_show() Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1305918786-7239-6-git-send-email-padovan@profusion.mobi \
    --to=padovan@profusion.mobi \
    --cc=fweisbec@gmail.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcin.slusarz@gmail.com \
    --cc=mingo@redhat.com \
    --cc=pq@iki.fi \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®