mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Arend van Spriel <arend@broadcom.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org,
	"John W. Linville" <linville@tuxdriver.com>,
	Dan Carpenter <error27@gmail.com>
Subject: Re: [RFC] lib: crc8: add new library module providing crc8 algorithm
Date: Sat, 21 May 2011 15:37:35 -0700	[thread overview]
Message-ID: <1306017455.3389.0.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <1306010973-5625-1-git-send-email-arend@broadcom.com> (sfid-20110521_225033_074451_F0976112)

On Sat, 2011-05-21 at 22:49 +0200, Arend van Spriel wrote:

> +/**
> + * enum - CRC8 constants
> + *
> + * @CRC8_INIT_VALUE: Initial CRC8 checksum value
> + * @CRC8_GOOD_VALUE: Good final CRC8 checksum value
> + *
> + * Constants for the crc8() function. Refer to its
> + * documentation how to use these values.
> + */
> +enum CRC8 {
> +	CRC8_INIT_VALUE	= 0xff,
> +	CRC8_GOOD_VALUE	= 0x9f
> +};

These seem a little out of place, wouldn't that be specific to how the
algorithm is used?

johannes


  reply	other threads:[~2011-05-21 22:35 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-21 20:49 Arend van Spriel
2011-05-21 22:37 ` Johannes Berg [this message]
2011-05-22  8:23   ` Arend van Spriel
2011-05-22 11:23 ` Alan Cox
2011-05-22 12:47   ` Arend van Spriel
2011-05-22 14:19     ` Alan Cox
2011-05-22 15:38       ` Arend van Spriel
2011-05-24  7:45       ` Arend van Spriel
2011-05-24  8:30         ` Arend van Spriel
2011-05-24  9:44         ` Alan Cox
2011-05-24 10:01           ` Arend van Spriel
2011-05-24 10:25             ` Rafał Miłecki
2011-05-24 10:40               ` Arend van Spriel
2011-05-24 10:27             ` Alan Cox
2011-05-24 10:38               ` Arend van Spriel
2011-05-24 12:57                 ` Alan Cox
2011-05-24 17:00                   ` Arend van Spriel
2011-05-22  8:08 Arend van Spriel
2011-05-22  8:59 ` Nicolas Kaiser
2011-05-22 12:49   ` Arend van Spriel
2011-05-24 20:23 Arend van Spriel
2011-05-24 22:52 ` George Spelvin
2011-05-25  5:21   ` Arend van Spriel
2011-05-25  5:46     ` George Spelvin
2011-05-25  6:49       ` Arend van Spriel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1306017455.3389.0.camel@jlt3.sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=akpm@linux-foundation.org \
    --cc=arend@broadcom.com \
    --cc=error27@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome