From: David Woodhouse <dwmw2@infradead.org>
To: "Valdis.Kletnieks@vt.edu" <Valdis.Kletnieks@vt.edu>
Cc: Youquan Song <youquan.song@linux.intel.com>,
"Song, Youquan" <youquan.song@intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"mingo@elte.hu" <mingo@elte.hu>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"hpa@zytor.com" <hpa@zytor.com>,
"hpa@linux.intel.com" <hpa@linux.intel.com>,
"Kay, Allen M" <allen.m.kay@intel.com>,
"Siddha, Suresh B" <suresh.b.siddha@intel.com>,
"Sankaran, Rajesh" <rajesh.sankaran@intel.com>,
"Mallick, Asit K" <asit.k.mallick@intel.com>,
"Liu, Kent" <kent.liu@intel.com>
Subject: Re: [PATCH v3] x86, vt-d: enable x2apic opt out
Date: Tue, 24 May 2011 08:38:47 +0100 [thread overview]
Message-ID: <1306222728.2627.49.camel@i7.infradead.org> (raw)
In-Reply-To: <17321.1306210686@localhost>
On Tue, 2011-05-24 at 05:18 +0100, Valdis.Kletnieks@vt.edu wrote:
> Do we want an actual WARN there, complete with stack traceback and
> all?
>
> Or did you intend a pr_warn or printk(KERN_WARNING or similar?
The traceback has been very useful in other BIOS issues, because it gets
tracked and counted on kerneloops.org along with platform
identification. So we have been able to track down the major offenders
of some of the most egregious BIOS stupidities and make *some* progress
on getting them to improve the untested dross they habitually turn out.
On *this* occasion perhaps a printk might suffice. After all, this
X2APIC_OPT_OUT was invented specifically as a way to allow the BIOS
engineers to get away without fixing their bugs. But then again, it
would also be useful to track how many people are doing it, and I cannot
think of a *legitimate* reason for a BIOS having to set it. So on
balance I'm happier with the WARN().
--
dwmw2
next prev parent reply other threads:[~2011-05-24 7:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-23 14:32 Youquan Song
2011-05-24 2:18 ` Valdis.Kletnieks
2011-05-24 15:36 ` Youquan Song
2011-05-24 4:18 ` Valdis.Kletnieks
2011-05-24 7:38 ` David Woodhouse [this message]
2011-05-24 12:13 ` Valdis.Kletnieks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1306222728.2627.49.camel@i7.infradead.org \
--to=dwmw2@infradead.org \
--cc=Valdis.Kletnieks@vt.edu \
--cc=akpm@linux-foundation.org \
--cc=allen.m.kay@intel.com \
--cc=asit.k.mallick@intel.com \
--cc=hpa@linux.intel.com \
--cc=hpa@zytor.com \
--cc=kent.liu@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rajesh.sankaran@intel.com \
--cc=suresh.b.siddha@intel.com \
--cc=tglx@linutronix.de \
--cc=youquan.song@intel.com \
--cc=youquan.song@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®