Re: [PATCH] sched: remove starvation in check_preempt_equal_prio()

[Steven Rostedt <rostedt@goodmis.org>]

On Tue, 2011-05-24 at 22:11 +0800, Hillf Danton wrote:
> On Tue, May 24, 2011 at 9:45 PM, Steven Rostedt <rostedt@goodmis.org> wrote:
> > On Tue, 2011-05-24 at 21:34 +0800, Hillf Danton wrote:
> >> If there are pushable tasks and they are high enough in priority, in which
> >> case task p is covered, the current could keep holding its CPU.
> >>
> >> Even if current task has to release its CPU, requeuing task p could result in
> >> starvation of tasks that are of same priority and have been waiting on RQ for
> >> a couple of hours:/
> >
> > Can you explain this better? Sounds like you are describing the
> > definition of FIFO. You are *not* suppose to preempt a FIFO task just
> 
> I dont want to redefine FIFO, but starvation needs attention, since
> the woken task is already off RQ, and its position on RQ is reshuffled.

Does this happen because your other patch doesn't do the work at wake up
anymore? That is, you require a schedule of the high prio task?

There should be no starvation if the currently woken RT task can
migrate, as it should simply go to another rq.

-- Steve