From: Eric Dumazet <eric.dumazet@gmail.com>
To: Christoph Lameter <cl@linux.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
James Morris <jmorris@namei.org>,
Pekka Enberg <penberg@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: SLUB regression in current Linus
Date: Wed, 25 May 2011 17:45:41 +0200 [thread overview]
Message-ID: <1306338341.2820.28.camel@edumazet-laptop> (raw)
In-Reply-To: <alpine.DEB.2.00.1105251003150.23309@router.home>
Le mercredi 25 mai 2011 à 10:04 -0500, Christoph Lameter a écrit :
> On Wed, 25 May 2011, Linus Torvalds wrote:
>
> > On Wed, May 25, 2011 at 7:47 AM, Christoph Lameter <cl@linux.com> wrote:
> > >
> > > So simply return the object. In the debug case we do not need all the other
> > > processing that unlock_out: does.
> >
> > So that patch looks like it should explain things.
> >
> > But exactly why don't we need the ->tid update and the ALLOC_SLOWPATH
> > stats? Both of them would seem to be equally valid for the debug case.
>
> We always fall back to the slow path in the debug case. So the tid update
> is useless.
tid change is updated anyway at the end of deactivate_slab()
next prev parent reply other threads:[~2011-05-25 15:45 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-24 11:52 James Morris
2011-05-24 12:04 ` James Morris
2011-05-24 14:08 ` Christoph Lameter
2011-05-24 22:15 ` James Morris
2011-05-25 14:47 ` Christoph Lameter
2011-05-25 14:57 ` Linus Torvalds
2011-05-25 15:04 ` Christoph Lameter
2011-05-25 15:45 ` Eric Dumazet [this message]
2011-05-25 16:31 ` Christoph Lameter
2011-05-25 15:42 ` Eric Dumazet
2011-05-25 16:29 ` Christoph Lameter
2011-05-24 23:03 ` Linus Torvalds
2011-05-25 5:22 ` Pekka Enberg
2011-05-25 14:25 ` Christoph Lameter
2011-05-25 7:40 ` Ingo Molnar
2011-05-25 8:58 ` [PATCH] Revert "slub: Remove node check in slab_free" Ingo Molnar
2011-05-25 11:13 ` Pekka Enberg
2011-05-25 14:54 ` Linus Torvalds
2011-05-25 12:42 ` SLUB regression in current Linus Jens Axboe
2011-05-25 23:53 ` David Rientjes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1306338341.2820.28.camel@edumazet-laptop \
--to=eric.dumazet@gmail.com \
--cc=cl@linux.com \
--cc=jmorris@namei.org \
--cc=linux-kernel@vger.kernel.org \
--cc=penberg@kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®